If you choose the Basic Button display, the button image will always use HTTP, which can lead to problems when using HTTPS/SSL.

Attached patch makes use of the AddThis::validateSecureUrl() method introduced in http://drupal.org/node/1403210, and changes validateSecureUrl() to a public method.

If you want to keep validateSecureUrl() private I think you'd need to refactor and hold the logic for big button/small button URLs in a public method in the AddThis class.

CommentFileSizeAuthor
#2 1734752-https-button-img-3.patch2.49 KBmatglas86
#2 1734752-https-button-img-3.txt2.01 KBmatglas86
addthis-secure-basic-button.patch1.68 KBstar-szr

Comments

matglas86’s picture

matglas86 commented

I would like to do a little refactoring here. Changing the name of the method and creating a public method then. At this point its stille posible without breaking the api

matglas86’s picture

matglas86 commented
StatusFileSize
new 1734752-https-button-img-3.txt2.01 KB
new 1734752-https-button-img-3.patch2.49 KB

I changed the methods a little bit. I prefere the seperation of this functionality because we can reuse it better. Feedback welcome.

matglas86’s picture

matglas86 commented
Issue summary: View changes
Status: Needs review » Fixed

Merging in this change to fix this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.