Provides a block with form to search for domains available for registration.

http://drupal.org/sandbox/luizcanet/1653294

git clone --recursive --branch master luizcanet@git.drupal.org:sandbox/luizcanet/1653294.git check_domain_availability

It's for Drupal 7

Comments

D4Ko’s picture

Status: Needs review » Needs work

An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.

You can find the results of the automated report at http://ventral.org/pareview/httpgitdrupalorgsandboxluizcanet1653294git

luizcanet’s picture

I made the changes. But now the script is saying that the README.txt is missing, but I see in the git repository.

patrickd’s picture

Your project page is not very detailed, please have a look at the tips for a great project page, you may also use HTML-tags for better structure.

The problem is that all your module files must be in the root of the git repository! move all files one level up and remove the subdirectory.

dwieeb’s picture

Hi,

  • I'm noticing many similarities between your module and the whois lookup module, which provides a mini form as a block. Remember, the Drupal community prefers collaboration over competition. Please list the differences between your module and the whois lookup module. One difference might be that your module is specifically for determining if a domain is available or not. If this is the only difference, please consider writing an extension module to the whois lookup module, using its services, instead of implementing your own.
  • As pactrickd mentioned, move the files out of the check_domain_availability directory and into the root of your git repository. Then the script will find your README.txt.
  • Since your module requires more than "Install as usual" as per your README, advise users how to install a whois service. My server did not have the whois package. You should probably detect this and display a message after module installation on how to install it.
  • You have a typo in your configuration form. It should be domain extensions, not extentions. Consider calling them top-level domains instead of domain extensions.
  • Is there a reason you're not supporting more popular top-level domains such as .com and .net?
  • Some of the strings in your code are enclosed by double quotes, and they don't need to be. Change them to single quotes to improve back-end performance. (So PHP doesn't interpolate them).
  • Add an .install file, and use hook_uninstall() to delete the variables you set in your module.
klausi’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.