User picture fixes and cleanup

I also need a fix for this. :-)

Nothing..? Seems pretty important... :|

In D5.x-dev, if i upload a new avatar image, is are define but still in server. D6.x-dev, the old image is deleted..

Fixed in D6.x-dev

Cool, but what about 5.x?

No one has a fix?

I wrote a little patch for you.. please tell me if solved your problem..

@gstash: You test my patch??

This issue does still exist in 6.x and HEAD and is reproducible with the original description- check Delete picture and upload a new picture.

Woah, forgot about this for a while... Sorry.

@ricabrantes: I tested, but to no avail. The problem is that the NEW picture is not uploaded when "delete picture" is also checked. So we need something like "if delete is checked AND a new picture is being added, simply overwrite with the new image"

Or something... Thanks though. :-)

The patch attached here, does anyone know if it works? Needs to be a fix for this as it's pretty fundamental in any user led site.
Cheers!

have you tested it?

Revised patch for 7.x that is tested and works.

Will this work for 5.x? Is there something for 5.x? Cheers,
Beechyboy

Updating patch with a test to make sure this doesn't regress again. As of now, has 1 fail. Not sure why. Letting testing bot have a try.

What are users to do for now? Is there a hack or work around? I'm looking at using form_alter to unset("the delete checkox");
What do people think?

#357403: Move user picture to managed files has fixed this in D7, so moving back for D6.

Backports the improvements from #357403: Move user picture to managed files which got the ok from webchick in 7.x:
- User picture form cleanup
- Fixes #173493: User picture fixes and cleanup

Please help review and mark as RTBC if it's ready.

Looking forward to backport to 5. How could I go about helping?

+    $form['picture']['picture_current'] = array(
+      '#markup' => theme('user_picture', (object)$edit),
+    );

Needs to be '#value' => ...

So in 5.x it should be... Right?

<?php
+    $form['picture']['picture_current'] = array(
+      '#value' => theme('user_picture', (object)$edit),
+    );
?>

Suppose it's enough to clean checkbox value if user picture was saved

Another cleanup, $form_state['values']['form_build_id'] is saved to data

re-tagging

Re-roll against current D6

Dave Reid, can you review this? I think this is a useful cleanup

patch still applies with offset

re-rolled but assuming this will just be closed anyways.