recaptchalib calls die() in various conditions. It would be much better to detect these conditions before they happen and handle them gracefully.

CommentFileSizeAuthor
#1 recaptcha_prevent_die_1734952.patch2.76 KBliam morland

Comments

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Fixed
StatusFileSize
new recaptcha_prevent_die_1734952.patch2.76 KB

Mostly fixed in b03a8d9; patch attached. There is one condition under which die() will be called that it not fixed here. New issue for that: #1734956: Fail gracefully instead of calling die() if reCAPTCHA server is down.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Assigned: liam morland » Unassigned
Status: Fixed » Patch (to be ported)
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

This is an expansion of the work in #1681746: Page is blank when reCAPTCHA not configured.

  • Liam Morland committed b03a8d9 on 7.x-1.x, 7.x-2.x 
    Issue #1734952: Fail gracefully instead of having recaptchalib call die...

  • Liam Morland committed b03a8d9 on 8.x-2.x 
    Issue #1734952: Fail gracefully instead of having recaptchalib call die...

  • Liam Morland committed b03a8d9 on 6.x-2.x 
    Issue #1734952: Fail gracefully instead of having recaptchalib call die...
hass’s picture

hass commented
Issue summary: View changes
Status: Patch (to be ported) » Fixed

  • hass committed 66e8a50 on 6.x-1.x 
    Issue #1734952 by hass: Fail gracefully instead of calling die()

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.