Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There are two typos in workbench_access_handler_field_section.inc
:
if ($view->base_table == 'node_revisions') {
$this->additional_fields['nid'] = array('table' => 'node_revisions', 'field' => 'nid');
}
else {
$this->additional_fields['nid'] = array('table' => 'node', 'field' => 'nid');
}
It's been driving me mad looking for this bug. This causes the "My Workbench" and "My Edits" admin pages to show the following debug message:
'Handler workbench_access_handler_field_section tried to add additional_field nid but node could not be added!'
Patch follows.
Comment | File | Size | Author |
---|---|---|---|
#1 | 1735382-01-Fix_node_revision_typo.patch | 840 bytes | zhangtaihao |
Comments
Comment #1
zhangtaihao CreditAttribution: zhangtaihao commentedHere's the patch.
There's also a typo in a comment. It has no effect, but should it be fixed anyway for consistency?
Here's a grep for all "node_revision" occurrences:
http://drupalcode.org/project/workbench_access.git?a=search&h=refs%2Fhea...
Comment #2
agentrickardWondering why no one caught this before....
Comment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedThank you for the patch. Saved me a headache!
Comment #4
g76 CreditAttribution: g76 commentedpatch worked for me, thank you:) . The workbench suite is incredible, thank you for all the hard work.
Comment #5
gmclelland CreditAttribution: gmclelland commentedThis worked for me. Thank you
Comment #6
Anonymous (not verified) CreditAttribution: Anonymous commentedRe: Wondering why no one caught this before....
It's amazing how things like this always sneak through now matter how much you test!
Comment #7
agentrickardCommitted. Thanks!
Comment #8
Anonymous (not verified) CreditAttribution: Anonymous commentedThank you, agentrickard, for you constant support of the Drupal community!
Comment #9
zhangtaihao CreditAttribution: zhangtaihao commentedagentrickard: Thanks for making time for this.