It would be nice to have a drush command to revert an Omega subtheme, so this can be done quickly and efficiently from the command line.

Currently this can be done with this command:

drush eval "omega_tools_revert_theme_settings('themename');"

But it would be nice to be able to do:

drush omega-revert themename

for applying use patch -p1 < patch_name.patch

CommentFileSizeAuthor
#1 1735534-1-omega_tools-drush_revert_command.patch2 KBpfrenssen

Comments

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Active » Needs review
StatusFileSize
new 1735534-1-omega_tools-drush_revert_command.patch2 KB
Kendall Totten’s picture

Kendall Totten commented

SImilarly it would be great to be able to export theme settings to the .info file and then revert. Is this possible with drush? Thanks!

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
commented

Good job!but some typo cleanup need.

+++ b/includes/omega_tools.drush.inc
@@ -112,4 +125,21 @@ function drush_omega_tools_omega_subtheme($name) {
\ No newline at end of file

It indicates that you do not have a newline (usually '\n', aka CR or CRLF) at the end of file.

+++ b/includes/omega_tools.drush.inc
@@ -112,4 +125,21 @@ function drush_omega_tools_omega_subtheme($name) {
--

Unnecessary spaces

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Needs review » Needs work

I reviewed my patch again and it seems to be fully compliant to coding standards, can you please elaborate where it goes wrong? I'm not introducing any whitespace errors.

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
commented

use drupal.org/project/dreditor to understand what i'm tying to say. Thx.

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
commented
Status: Needs work » Reviewed & tested by the community

I got you! All my comments was about patch in git style, but as i see your patch applied by "patch" command not "git apply" (as i thought).

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
commented

Thx a lot for your patch, good feature!

pfrenssen’s picture

pfrenssen
Location Sofia
commented

Yes I use git format-patch to generate my patches. This includes some metadata which can be helpful for the maintainers. I did not realise this was incompatible with dreditor.

Thanks for the review!

fubhy’s picture

fubhy commented
Status: Reviewed & tested by the community » Closed (won't fix)

I do not plan to add this to Omega Tools 3.x anymore. Omega 4.x comes with support for this out-of-the-box as the drush integration has been ported over to the theme layer entirely and got improved and extended quite a bit. Thanks for the idea though (this issue caused me to add it to 4.x).

fubhy’s picture

fubhy commented
Issue summary: View changes

Updated issue summary.