There is now a GetID3 module.
IMHO Audio module must depend on it :$

Comments

drewish’s picture

Status: Active » Postponed

first,there's no published releases. that's not a good sign in terms of module stability. second i'm reluctant to add more dependencies to this module.

mfb’s picture

Seems like a good idea, once it's been released.

zirafa’s picture

Unless it comes prepackaged with the getID3 library (which it could since it's GNU I guess) it wouldn't be much help since you'd still have to download the library.

Something to keep an eye on for sure, but agreed that this module is already starting to have a lot of dependencies.

robloach’s picture

Unfortunately the getID3 PHP Library can't be packaged with the solution within the CVS because its considered a third party contender.

The reason a dedicated module for getID3() is a good idea is because it abstracts the awesome getID3 stuff in audio_getid3.module away from it so that other modules can use its functionality. GetID3 is used by a couple of different modules (MediaField, audio_getid3, flexinode_getid3 back in the day, etc), and having a dedicated module to manage getID3's settings means that you don't have to have a number of different installations of getID3 at any given time. The goal of the getID3() module is to not only ensure the user has installed the getID3 PHP library properly, but also provide a simplistic API for developers to easily use the getID3 library without having to worry whether it's installed.

As it stands right now, it contains small amounts of code from both audio_getid3.module and mediafield.inc, and a couple of additional usability features. Drewish, your code in audio_getid3.module really helped with this and there are still a few things missing that I'd like to see in the getID3 module. I'm sure you'd like to tackle those...

bonobo’s picture

Status: Postponed » Fixed

The D6 version of Audio now leverages the getID3 module -- setting to fixed.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.