Node Title Optional [#173614]

Comment	File	Size	Author
#9	auto_nodetitle.module.titleoptional_3.patch	3.68 KB	robloach
#7	auto_nodetitle.module.titleoptional_2.patch	3.08 KB	robloach
#2	auto_nodetitle.module.titleoptional.patch	1.65 KB	robloach

Comment #1

fago

German

Vienna

commented 8 September 2007 at 13:28

that sounds useful - would be nice if you could provide a patch for that :)

Log in or register to post comments

Comment #2

robloach

he/him

commented 10 September 2007 at 15:02

Status:

Active

» Needs review

Status	File	Size
new	auto_nodetitle.module.titleoptional.patch	1.65 KB

Sounds like a deal ;-) .

Log in or register to post comments

Comment #3

robloach

he/him

commented 27 September 2007 at 09:11

Priority:

Normal

» Critical

You mind reviewing this patch?

Log in or register to post comments

Comment #4

robloach

he/him

commented 27 September 2007 at 11:11

To test it, apply the patch, and then edit a content type. Under "Automatically generate the node title and hide the node title field.", you'll see "Title Optional". Check Title Optional, but don't check Automatically Generate. Now when you edit/add a node, the title will be there, but it will be optional. Not putting in the title will generate the title for you using the provided pattern. Putting in the title will use the given title.

Log in or register to post comments

Comment #5

fago

German

Vienna

commented 3 October 2007 at 19:07

Status:

Needs review

» Needs work

ops, sry for the late review. I somehow overlooked that patch. sry!

However I don't like the UI you build. Now there are two checkboxes - but it doesn't make sense to check both. So perhaps, there would be better radio buttons:
* Disabled (default)
* Automatically generate the node title and hide the node title field.
* Automatically generate the node title, if the title field is left empty.

Then you have introduced a new variable, but you forgot to clean it up on module uninstallation.

Log in or register to post comments

Comment #6

robloach

he/him

commented 3 October 2007 at 19:13

Assigned:

Unassigned

» robloach

I like the idea of the radio buttons! I'll have a look at it sometime in the near future.

Log in or register to post comments

Comment #7

robloach

he/him

commented 3 October 2007 at 20:11

Status:

Needs work

» Needs review

Status	File	Size
new	auto_nodetitle.module.titleoptional_2.patch	3.08 KB

Refactored using the single ant variable, with the three radio buttons as specified in your post above.

Log in or register to post comments

Comment #8

fago

German

Vienna

commented 4 October 2007 at 08:15

Status:

Needs review

» Needs work

wow, that was quick... :)

much better, however I'd like to see some minor improvements before committing it:

* instead of using $nodetitlestatus, implement a short function "auto_nodetitle_get_setting($type)" to shorten the if(). don't worry about calls to variable_get, they aren't expensive.
* please use defines for the settings 1 and 2, so that the code is more readable. e.g. AUTO_NODETITLE_OPTIONAL. This may even make some comments redundant.

Log in or register to post comments

Comment #9

robloach

he/him

commented 4 October 2007 at 15:48

Status:

Needs work

» Needs review

Status	File	Size
new	auto_nodetitle.module.titleoptional_3.patch	3.68 KB

So demanding! ;-)

This patch replaces $nodetitlestatus with a new auto_notetitle_get_setting($type) function, and uses some new constants: AUTO_NODETITLE_DISABLED, AUTO_NODETITLE_ENABLED and AUTO_NODETITLE_OPTIONAL.