Content Type Filter

Your module is really short, see http://groups.drupal.org/node/195848.
But this module still can be approved manually as full module.

You are not using Drupal coding standards. See http://ventral.org/pareview/httpgitdrupalorgsandboxpurab1736392git.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

$url_params = explode('/', $_GET['q']);
You should use arg() function rather than exploding $_GET['q'].

In my opinion there should be a select list where you can choose which content type you want to show. For now I must put all of the content types directly. End user not always remembers machine name of content types.

What's more such functionality (and a lot more) have VBO Views with contextual filters. Personally I think VBO is better choice than your module because it is gives more user friendly interface.

There are two notices:
Notice: Undefined index: node_overview_filter in content_type_filter_form_alter() (line 13 of C:\wamp\www\dashboards\sites\all\modules\drupal.org\content_type_filter\content_type_filter.module).
Notice: Undefined offset: 1 in content_type_filter_form_alter() (line 13 of C:\wamp\www\dashboards\sites\all\modules\drupal.org\content_type_filter\content_type_filter.module).

I also do not understand why status is published automatically. I cannot see my unpublished nodes because of two filters that excluding each other.

Whats more if I make a typo I get following error:
Notice: Undefined index: art in node_filter_form() (line 159 of C:\wamp\www\dashboards\modules\node\node.admin.inc).

Hi,

# Remove "version" from your info file.
# You have the '?>' at the end of your file 'content_type_filter.module'. It's discouraged.
# Remove all old CVS $Id tags.

Hello,

Consider gaining Review bonus to have your application reviewed sooner in the future.

It appears that you do not commited any changes. Please, do it so we can look into new code.

Also describe how your module differs from standard filtering (which is handy) or other modules that allow to create similar views (as VBO). Beside it is lightweight it also duplicates some of the functionality and duplication is a big problem on drupal.org.

Hi,
1) In your project page you should include more information about your module so that it can be easy for others to understand. Right now it is giving only one line description.
2) Search for similar modules yourself and explain how it is different from other module.
3) You should provide comments in your module. For further details you can refer: http://drupal.org/coding-standards.
4) Moreover, you can correct following things in your content_type_filter.module.
a)Line 26: Control statements should have one space between the control keyword and opening parenthesis
if(empty($_SESSION['node_overview_filter'])){

b)Line 26: use a space between the closing parenthesis and the open bracket

if(empty($_SESSION['node_overview_filter'])){

c)Line 39: use a space between the closing parenthesis and the open bracket

} else if ($_SESSION['node_overview_filter'][1][1] != arg(3)){

d)Line 39: else statements should begin on a new line

} else if ($_SESSION['node_overview_filter'][1][1] != arg(3)){

e)Line 39: Use "elseif" in place of "else if"

} else if ($_SESSION['node_overview_filter'][1][1] != arg(3)){

Hi,
For the 4th point explained above. you can use:-
1) if(empty($_SESSION['node_overview_filter'])) {
2) } else if ($_SESSION['node_overview_filter'][1][1] != arg(3)) {
3) }
elseif ($_SESSION['node_overview_filter'][1][1] != arg(3)) {
4) }
elseif ($_SESSION['node_overview_filter'][1][1] != arg(3)) {

This version is not compatible with Drupal 7.x so check for this also.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

add project URL