Onwards from http://drupal.org/node/1189184#comment-6285584,

- @sun noted that try/catch statements should not be on the same line
- @attiks noted a debug line left around
- @webchick noted $exc should be renamed to $exception

The first two are already fixed, the last one still needs to be fixed.

CommentFileSizeAuthor
#3 code_style-1737186-3.patch1.29 KBsxnc
locale-catch-259.patch1.28 KBgábor hojtsy

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Needs review

Send to testbot at first anyway, should be set back to needs work after unless a fixed patch is provided :)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

The variable is still to be renamed.

sxnc’s picture

sxnc commented
Status: Needs work » Needs review
StatusFileSize
new code_style-1737186-3.patch1.29 KB

Fixing issue #3

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Ok, looks like the exception data is not used in fact, since we already know the file and can report the error. If this comes back green, it should be RTBC then.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Should be good to go!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -sprint

Off of the sprint then. Thanks!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: +sprint

Putting back on sprint just for easier tracking of our work. Will remove later next week.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -sprint

Removing as promised. We do not need a change notice or changelog entry for this.

Automatically closed -- issue fixed for 2 weeks with no activity.