Closed (duplicate)
Project:
Excerpt
Version:
5.x-1.2
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Anonymous (not verified)
Created:
7 Sep 2007 at 15:01 UTC
Updated:
25 Mar 2017 at 20:41 UTC
I'm using the development version now, but I'd prefer to leave my projects using a valid release of this module. The development version is always flagged as needing an update in the update status module. The release for 5.x-1.2 is not recognized by Drupal. There's no info file. The module also contains some bad code:
function excerpt_nodeapi(&$node, $op, $teaser) {
switch ($op) {
case 'validate':
case 'load':
if (trim($node->teaser) == '') {
$node->teaser = node_teaser($node->body);
}
case 'load':
if ($node->teaser=='') {
$node->teaser = node_teaser($node->body);
}
break;
case 'view':
$node->readmore = ($node->teaser != $node->body);
break;
break;
}
}
Why two breaks for the 'view' case? Why two behaviors for the 'load' case? It looks like a careless paste job.
It's been several months, and it's time to have a proper release. Is someone maintaining this project?
Comments
Comment #1
jiangxijay commented"It's been several months, and it's time to have a proper release. Is someone maintaining this project?"
Agreed.
Subscribing.
Comment #2
peterx commentedI set up my Drupal 5 Excerpt with the following excerpt.info file:
You can then remove the following lines from excerpt_help():
See also http://drupal.org/node/182551 for Drupal 6.
petermoulding.com/web_architect
Comment #3
hayesr commented