some utf-8 files begining with a header like 0xEF 0xBB 0xBF

CommentFileSizeAuthor
#3 import.BOM_.patch707 bytesGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Project: Auto locale import » Drupal core
Version: 5.x-1.x-dev » 6.x-dev
Component: Code » language system
Category: feature » bug

Well, it is not a good idea to have files with UTF8 BOM, it causes you lots of complications. So the interim solution is to remove that yourself.

The import itself is done by Drupal (whether with autolocale module or Drupal 6 built-in), not autolocale, so the Drupal importer cannot handle such files then. Which means this should be fixed there.

Gábor Hojtsy’s picture

Title: do handle utf-8 text file's header » Handle UTF-8 byte order mark in .po files when importing

Fixing title.

Gábor Hojtsy’s picture

Title: Handle UTF-8 byte order mark in .po files when importing » UTF-8 byte order mark breaks import
Status: Active » Needs review
FileSize
707 bytes

OK, here is a patch for review. Since there was a second guy who came with this problem (also from Hungary), and this really looks straightforward to fix, why not do it? Please review!

aries’s picture

It works for me.

Gábor Hojtsy’s picture

Version: 6.x-dev » 5.x-dev
Status: Needs review » Reviewed & tested by the community

Great. Committed to Drupal 6. Let's get this into the next Drupal 5.x also.

drumm’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 5.x.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.