Download & Extend
Drupal Commerce » Issues

Precalculated price uses empty string for language

Posted by AndyF on August 19, 2012 at 10:39am
Project:Drupal Commerce
Version:7.x-1.x-dev
Component:Product pricing
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

In commerce_product_pre_calculate_sell_prices() the language code is set to the empty string if the product doesn't have a language set; I think that should be LANGUAGE_NONE?

Login or register to post comments

Comments

#1

Posted by AndyF on August 19, 2012 at 10:41am
Status:active» needs review

Thanks

AttachmentSizeStatusTest resultOperations
commerce-batch_precalculate_price_language-1739600-1.patch886 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 3,589 pass(es).View details

#2

Posted by rszrama on September 26, 2012 at 3:32am
Status:needs review» needs work

I think what you have is correct, but we'll need an update function before we can commit this.

#3

Posted by AndyF on September 29, 2012 at 5:51pm
Status:needs work» needs review

Thanks, hope this is ok. I wasn't sure if the hook_update should return a message?

AttachmentSizeStatusTest resultOperations
commerce-batch_precalculate_price_language-1739600-3.patch1.75 KBIdlePASSED: [[SimpleTest]]: [MySQL] 3,587 pass(es).View details

#4

Posted by AndyF on October 1, 2012 at 8:12am

Oops, used the wrong table name in the comment.

AttachmentSizeStatusTest resultOperations
commerce-batch_precalculate_price_language-1739600-4.patch1.78 KBIdlePASSED: [[SimpleTest]]: [MySQL] 3,587 pass(es).View details

#5

Posted by rszrama on October 1, 2012 at 3:10pm
Status:needs review» fixed

Thanks, Andy. Committed just now. : )

#6

Posted by System Message on October 15, 2012 at 3:11pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.