By Installing this widget your users can see weather updates for their location on your website. You can get forecast, various units and really beautiful, eye pleasing weather status that instantly seeks your attention. Plugin loads from our optimised servers to server the best version according to browser loading the plugin and be as snappy as possible. Works with IE 8+, FF 3+, Chrome, Opera, Safari, Android 2.3+, iOS 4+.
Project sandbox page: http://drupal.org/sandbox/zenogaisis/1739802
Project homepage: http://www.weatherfor.us/
Git URL: git.drupal.org:sandbox/zenogaisis/1739802.git
Drupal: 6.x
Comments
Comment #1
dwieeb commentedHi,
You are working out of the
masterbranch on git. Please specify a major version branch such as6.x-1.x. For more information, here is documentation on release naming conventions and creating a branch in git.An automated review has found some issues with your code. Please correct them in accordance to Drupal Coding Standards. You can check your code for problems before committing to the repository by using Drupal Code Sniffer.
Please:
404 Not Found - http://localhost/weatherist/php//load.php?skin=mini.installfile with a function that implements hook_uninstall() and use variable_del() on the variables that you're setting.viewsfolder to something else. That could be construed as attempted integration with the views module.Comment #2
dwieeb commentedComment #3
zenogaisis commentedI've fixed all the issues have a look.
Comment #4
dwieeb commentedYou're not supposed to tag until it's ready for release. When you tag something, d.o will create a release package of the code of that tag.
And it doesn't look like you've fixed all the issues. There's still no documentation of hook and non-hook functions in your
.moduleand other files and you still have a blank hook_menu() and there's still a lot of issues with your code as seen in this automatic review: http://ventral.org/pareview/httpgitdrupalorgsandboxzenogaisis1739802git. You must fix these.Comment #5
zenogaisis commentedFixed issues this time also verified here are results for automated test http://ventral.org/pareview/httpgitdrupalorgsandboxzenogaisis1739802git-6x-1x. Please verify if i missed something.
Comment #6
zenogaisis commentedAny issues?
Comment #7
zenogaisis commentedRe-applied.
Comment #8
avpaderno