By Installing this widget your users can see weather updates for their location on your website. You can get forecast, various units and really beautiful, eye pleasing weather status that instantly seeks your attention. Plugin loads from our optimised servers to server the best version according to browser loading the plugin and be as snappy as possible. Works with IE 8+, FF 3+, Chrome, Opera, Safari, Android 2.3+, iOS 4+.

Project sandbox page: http://drupal.org/sandbox/zenogaisis/1739802
Project homepage: http://www.weatherfor.us/
Git URL: git.drupal.org:sandbox/zenogaisis/1739802.git
Drupal: 6.x

Comments

dwieeb’s picture

Status: Needs work » Needs review

Hi,

You are working out of the master branch on git. Please specify a major version branch such as 6.x-1.x. For more information, here is documentation on release naming conventions and creating a branch in git.

An automated review has found some issues with your code. Please correct them in accordance to Drupal Coding Standards. You can check your code for problems before committing to the repository by using Drupal Code Sniffer.

Please:

  • Double-check to make sure your minion view is working. It wasn't loading for me even though the explicit view was. I get a 404 error in console: 404 Not Found - http://localhost/weatherist/php//load.php?skin=mini
  • Document your code appropriately according to the Drupal documentation standards.
  • Remove your variables once the module is uninstalled. Create an .install file with a function that implements hook_uninstall() and use variable_del() on the variables that you're setting.
  • Add a new line at the end of each of your files. It's a git thing.
  • Consider renaming the views folder to something else. That could be construed as attempted integration with the views module.
  • Correct the typo on line 28. Change "Wide huge 720p widget" to "Wide huge 720px widget".
  • Implement or remove your hook_menu().
dwieeb’s picture

Status: Needs review » Needs work
zenogaisis’s picture

I've fixed all the issues have a look.

dwieeb’s picture

Status: Needs review » Needs work

You're not supposed to tag until it's ready for release. When you tag something, d.o will create a release package of the code of that tag.

And it doesn't look like you've fixed all the issues. There's still no documentation of hook and non-hook functions in your .module and other files and you still have a blank hook_menu() and there's still a lot of issues with your code as seen in this automatic review: http://ventral.org/pareview/httpgitdrupalorgsandboxzenogaisis1739802git. You must fix these.

zenogaisis’s picture

Status: Needs work » Needs review

Fixed issues this time also verified here are results for automated test http://ventral.org/pareview/httpgitdrupalorgsandboxzenogaisis1739802git-6x-1x. Please verify if i missed something.

zenogaisis’s picture

Priority: Normal » Major

Any issues?

zenogaisis’s picture

Status: Needs review » Closed (duplicate)

Re-applied.

avpaderno’s picture

Title: Weather for us widgets » [D6] Weather for us widgets
Priority: Major » Normal
Issue summary: View changes
Related issues: +#1742960: [D6] Weather for us widgets