Move module-dependent settings into API and only display status on settings page
Susurrus - September 8, 2007 - 17:21
| Project: | Filemanager |
| Version: | 5.x-1.x-dev |
| Component: | User interface |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
I think that almost all of the settings on the filemanager admin page should be moved solely into the API. Modules using this API can specify these settings and expose them to the administrator if they want to. I also think that the public/private directories could possibly be moved to be per area, so you could theoretically give each area its own folder, which could be nice.
I just think that since this is a module API it makes more sense for each module that uses it to explicitly set the options that they want and then expose any options they want changeable to the user through their own admin settings page.
#1
Does no one have any comment on this? It would be great to offer more control to the modules using this API instead of requiring further user configuration.
#2
I've done a little of what I proposed, and that is to separate the API a little more from the user and put more control in the hands of the modules. This patch changes filemanager so that it no longer controls the settings of each area and that modules are responsible for implementing this themselves. Documentation at about this has been added.
To test this functionality, a patch against 5.x-1.x-dev of the attachment module has also been provided. The settings for attachment.module now control the private and size settings for filemanager.module.