Some more errors from using unknown variables (#1740944: Use error_level=2 for all local development, these ones show the first time that the checkout form is submitted.

Notice: Undefined index: rate in uc_quote_order() (line 542 of ubercart/shipping/uc_quote/uc_quote.module).
Notice: Undefined index: quote_form in uc_quote_order() (line 542 of ubercart/shipping/uc_quote/uc_quote.module).
CommentFileSizeAuthor
#2 ubercart-n1740994.patch892 bytesdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review

This fills in some empty values for the two missing variables, but I haven't dug into it any further to see *why* they're missing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new ubercart-n1740994.patch892 bytes

Ah, the patch file.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

FYI the patch above resolves the symptoms, I'm just not sure if there isn't another problem elsewhere that ultimately *causes* the symptom.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I don't even see where that "quote_form" column is actually used; we go to the effort of storing it in the database but it only ever seems to get read from a session variable. In 7.x it's been dropped entirely; I wonder if we can do the same here.

I also can't reproduce the 'rate' message, which shipping quote method are you using? They should always return a valid rate value.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Fixed

Committed, as I guess it can't hurt to guard against this and these are sensible defaults. I still can't reproduce the 'rate' message though.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

btw I came across the second error when using the flatrate shipping option in 6.x-2.10, in uc_quote_order() with $op='save' the $order->quote object looks like this:

... (Array, 3 elements)
    method (String, 10 characters ) flatrate_1
    accessorials (String, 1 characters ) 0
    rate (Float) 6.15

As you can see there is no 'quote_form' value.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Detailed how the errors show.