Closed (fixed)
Project:
Goofy
Component:
Miscellaneous
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Feb 2005 at 11:45 UTC
Updated:
10 Apr 2005 at 09:15 UTC
Jump to comment: Most recent file
As mention in http://drupal.org/node/11929 i have removed the JavaScript from goofy. In this version all the Java is gone but a also moved the stule sheet to a externall file and changes a bit of the comment function.
e.g. i removed the if statement in the commend script, i don't see the point of it.
please test if i did break something.
Mad Maks
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | goofy_xthml11 | 12.27 KB | Mordio |
| #3 | goofy.patch | 17.76 KB | Mad Maks |
| #1 | style.css | 2.05 KB | Mad Maks |
| goofy_modifed_0 | 11.8 KB | Mad Maks |
Comments
Comment #1
Mad Maks commentedthe style sheet
Comment #2
LimitMan commentedHey man ... Great .. with this two files You solowed all problems.
1. Header information error dose not apear any more (and it was apearing at moment of submiting ANY form)
2. I think that crazy guest number is now ok (but I also think that was google crawling bots, since I was tracing logs. They are coming from adsence)
3. Java Script error is not apearing on first opening of page (like it did with original goofy)
4. And finaly I can put adsence on my page :-)
I will see if I notice some more bugs, but for now on it looks ok :-)
(just to mention I am admin of zawireless.afz.biz that posted that bug report)
Thanks for doing this. Goofy communtiy owns You ;-)
Comment #3
Mad Maks commentedpatch agains HEAD
Comment #4
Mordio commentedHello!
I made your modification XHTML 1.1 compliant. I post it here in case anybody is interested in it. To make it look properly in Firefox (or any other Gecko based-browser) you have to add the follwowing lines to your style.css:
-- Mordio
Comment #5
TDobes commentedFYI: I'll be committing this soon (after some minimal testing of my own). If anyone knows of any bugs, speak now, please. :-)
Comment #6
Mad Maks commentedTDobes, what is the status of your testing?
Comment #7
TDobes commentedThanks for your work, Mad Maks.
Also thanks to Mordio for the "display: block" tip.
I have committed a somewhat modified version of this patch to CVS HEAD. (A few tweaks to make the theme XHTML rather than HTML and whitespace cleanup)
I did my best to maintain the exact same appearance as the javascript version. Please open a new bug report if anyone finds any problems.
Comment #8
(not verified) commented