Download & Extend
OpenLayers » Issues

Rewrite the function get_group_wkt() using geoPHP

Posted by Pol on August 20, 2012 at 3:39pm
Project:OpenLayers
Version:7.x-2.x-dev
Component:OL Views
Category:task
Priority:normal
Assigned:Pol
Status:closed (fixed)

Issue Summary

Now that this geoPHP bug has been fixed, we can replace the function get_group_wkt() with:

<?php
  /**
   * Combine all group wkt into a single geometry collection
   *
   * openlayers_views_style_data specific
   */
  function get_group_wkt($wkt_array) {
    geophp_load();
    $geophp = geoPHP::load($wkt_array, 'wkt');
    return $geophp->out('wkt');
  }
?>

I'm looking for people to test and give me feedback. The patch is following.

Login or register to post comments

Comments

#1

Posted by Pol on August 20, 2012 at 3:41pm
Status:active» needs review

For OL 7.x-2.x.

AttachmentSizeStatusTest resultOperations
0001-Issue-1741220-Rewrite-get_group_wkt.patch3.5 KBIdlePASSED: [[SimpleTest]]: [MySQL] 238 pass(es).View details

#2

Posted by Brandonian on August 21, 2012 at 4:52am

Wouldn't this break if a site hasn't enabled geoPHP? Unless something's changed recently, geoPHP isn't a requirement for OL 7.x-2.x

#3

Posted by Pol on August 21, 2012 at 5:07am

True, it should be a requirement, I committed the patch.

http://drupalcode.org/project/openlayers.git/commit/edc9290

Thanks !

#4

Posted by Pol on December 26, 2012 at 4:25pm
Status:needs review» fixed

Patch committed.

#5

Posted by System Message on January 9, 2013 at 4:30pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.