Fix coding standards issue

johandc - September 9, 2007 - 20:37
Project:Front Page
Version:HEAD
Component:Code
Category:task
Priority:normal
Assigned:beginner
Status:closed
Description

Hi, thanks for a great module.

I have ported and tested the module with drupal 6.x
Attached patch file.

Works like a charm :-)

AttachmentSize
front-patch-5.x-1.9-to-6.x.patch3.37 KB

#1

johandc - September 9, 2007 - 20:48
Title:Port to support 6.x» Update of patch to fix coding standards issue!

While i was at it i ran the coder module and fixed all coding standard issues in the 6.x patch.

Attached new patch file.

AttachmentSize
front-patch-5.x-1.9-to-6.x_0.patch8.78 KB

#2

Dublin Drupaller - September 28, 2007 - 12:16
Assigned to:Anonymous» Dublin Drupaller

thanks for the patch.....will test and apply the patch asap now that Drupal 6 beta is out.

cheers

Dub

#3

beginner - April 19, 2008 - 11:58
Title:Update of patch to fix coding standards issue!» Fix coding standards issue
Version:5.x-1.9» HEAD
Category:feature request» task
Priority:critical» normal
Status:patch (code needs review)» active

Well, Drupal 6 is out already, so the patch is no longer valid.
The title shouldn't have been changed in comment #1: thus we forgot there was an upgrade patch in this issue.

It could be a good idea at some time to run the module against coder.module, and fix code style issues that may still remain (a lot has been cleaned, already).

#4

beginner - April 29, 2008 - 08:09
Assigned to:Dublin Drupaller» beginner
Status:active» fixed

I ran coder.module and found only a handful of minor issues.
fixed in HEAD and D6--1-0.

#5

Anonymous (not verified) - May 13, 2008 - 08:11
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.