Download & Extend
Front Page » Issues

Fix coding standards issue

Posted by johandc on September 9, 2007 at 8:37pm
Project:Front Page
Version:master
Component:Code
Category:task
Priority:normal
Assigned:beginner
Status:closed (fixed)

Issue Summary

Hi, thanks for a great module.

I have ported and tested the module with drupal 6.x
Attached patch file.

Works like a charm :-)

AttachmentSize
front-patch-5.x-1.9-to-6.x.patch3.37 KB
Login or register to post comments

Comments

#1

Posted by johandc on September 9, 2007 at 8:48pm
Title:Port to support 6.x» Update of patch to fix coding standards issue!

While i was at it i ran the coder module and fixed all coding standard issues in the 6.x patch.

Attached new patch file.

AttachmentSize
front-patch-5.x-1.9-to-6.x_0.patch 8.78 KB

#2

Posted by Dublin Drupaller on September 28, 2007 at 12:16pm
Assigned to:Anonymous» Dublin Drupaller

thanks for the patch.....will test and apply the patch asap now that Drupal 6 beta is out.

cheers

Dub

#3

Posted by beginner on April 19, 2008 at 11:58am
Title:Update of patch to fix coding standards issue!» Fix coding standards issue
Version:5.x-1.9» master
Category:feature request» task
Priority:critical» normal
Status:needs review» active

Well, Drupal 6 is out already, so the patch is no longer valid.
The title shouldn't have been changed in comment #1: thus we forgot there was an upgrade patch in this issue.

It could be a good idea at some time to run the module against coder.module, and fix code style issues that may still remain (a lot has been cleaned, already).

#4

Posted by beginner on April 29, 2008 at 8:09am
Assigned to:Dublin Drupaller» beginner
Status:active» fixed

I ran coder.module and found only a handful of minor issues.
fixed in HEAD and D6--1-0.

#5

Posted by Anonymous (not verified) on May 13, 2008 at 8:11am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

nobody click here