Download & Extend
Views » Issues

Enabled displays get the disabled link class

Posted by osopolar on August 21, 2012 at 2:10pm
Project:Views
Version:7.x-3.x-dev
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Enabled and disabled tabs have both the css class views-display-deleted-link.

Because disabled class is set "if (empty($display->options['enabled']))" but disabled tabs have the option $display->display_options['enabled'] = FALSE;

The check should be:

<?php
if (isset($display->display_options['enabled']) && !$display->display_options['enabled']) {...}
?>
Login or register to post comments

Comments

#1

Posted by osopolar on August 21, 2012 at 2:13pm

Patch for this fix.

AttachmentSizeStatusTest resultOperations
views_ui-theme-display-deleted-link-1742732-1.patch638 bytesIgnored: Check issue status.NoneNone

#2

Posted by dawehner on August 21, 2012 at 3:52pm
Title:Theme disabled Tabs (views_ui)» Enabled displays get the disabled link class
Status:active» fixed

This patch totally makes sense, thanks for that, committed to both 8.x-3.x and 7.x-3.x

Commit:
http://drupalcode.org/project/views.git/commit/80f9cf8

#3

Posted by System Message on September 4, 2012 at 4:01pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.