Verify Maintainers tab and its permissions (project_maintainers_tab.feature, edit, vcs, maintainers, issues, releases)

There is no step definition specifically testing Write to VCS. It will require adding and committing locally, and the test will be a successful push.

Unassigning from me.

project_maintainers_tab_edit.feature and project_maintainers_tab_vcs.feature are right, but all the other files are not using Unix-compatible line endings and need to be revised so they do.

The actual content of the files it looking great, although project_maintainers_tab_vcs.feature needs to clean up after itself so that the repository it creates is removed at the end of the scenario.

This looks great for now and I'm moving along to code review, but I think that's going to need work because if the scenarios are run out of order, I see:

  @gitrepo
  Scenario: Git user does a push a commit to the repository  # features/project/project_maintainers_tab_vcs.feature:23
    Given I am logged in as "git user"                       # FeatureContext::iAmLoggedInAs()
    And I am on the Version control tab                      # FeatureContext::iAmOnTheVersionControlTab()
PHP Fatal error:  Call to a member function getHTML() on a non-object in /home/melissa/doobie/features/bootstrap/FeatureContext.php on line 385

I'll be re-visiting the test data issue with sdboyer, but in the meantime, I doing a check that the value is present and throwing a pretty exception if it is not is in order.

I've tagged this issue with dependent scenarios and tagged each dependent scenario with @dependent.

I'm getting prompted for the gituser password:

  @gitrepo @dependent
  Scenario: Git user does a push a commit to the repository  # features/project/project_maintainers_tab_vcs.feature:27
    Given I am logged in as "git user"                       # FeatureContext::iAmLoggedInAs()
    And I am on the Version control tab                      # FeatureContext::iAmOnTheVersionControlTab()
gituser@git6.devdrupal.org's password: 
gituser@git6.devdrupal.org's password: 
    When I clone the repo                                    # FeatureContext::iCloneTheRepo()
    Then I should be able to push a commit to the repository # FeatureContext::iShouldBeAbleToPushACommitToTheRepository()

Looks like good progress!

I fixed the spelling error in the exception and pushed it in 518efd6cc8732

If the repo doesn't initialize, we get some less-than-helpful text in the subsequent failures. Can you look into that?

  Scenario: Create a sandbox project and initialize repo         # features/project/user_profile_projects_section.feature:10
    When I visit "/node/add/project-project"                     # FeatureContext::iVisit()
    And I create a "module"                                      # FeatureContext::iCreateA()
    And I see the project title                                  # FeatureContext::iShouldSeeTheProjectTitle()
    And I am on the Version control tab                          # FeatureContext::iAmOnTheVersionControlTab()
    And I initialize the repository                              # FeatureContext::iInitializeTheRepository()
      The page did not contian any code block
    And I follow "Version control"                               # FeatureContext::clickLink()
    Then I should see "Setting up repository for the first time" # FeatureContext::assertPageContainsText()

  @gitrepo @dependent
  Scenario: Commit to the above sandbox project and verify the same # features/project/user_profile_projects_section.feature:20
    When I visit the Version control tab                            # FeatureContext::iAmOnTheVersionControlTab()
    And I clone the repo                                            # FeatureContext::iCloneTheRepo()
      Notice: Undefined variable: url in features/bootstrap/FeatureContext.php line 207

I read comment number #15 and reviewed the commit it linked to: features/project/user_profile_projects_section.feature instead of features/project/project_maintainers_tab_vcs.feature ... now I know how I went astray.

So, regarding project_maintainers_tab_vcs.feature

The exceptions are much more helpful, and I'm seeing one of them in the third scenario.
It's consistently failing on the "I clone the repo" step as is #1706800: Edit profile tab(git_access_check.feature):

  @gitrepo @dependent
  Scenario: Git user does a push a commit to the repository  # features/project/project_maintainers_tab_vcs.feature:28
    Given I am logged in as "git user"                       # FeatureContext::iAmLoggedInAs()
    And I am on the Version control tab                      # FeatureContext::iAmOnTheVersionControlTab()
    When I clone the repo                                    # FeatureContext::iCloneTheRepo()
      The clone did not workspawn git clone --recursive --branch master ssh://gituser@git6.devdrupal.org:2020/sandbox/gitvetteduser/1780943.git znafgajp2jnfgssv
      Cloning into 'znafgajp2jnfgssv'...
      gituser@git6.devdrupal.org's password: 
      Permission denied, please try again.
      gituser@git6.devdrupal.org's password: 
    Then I should be able to push a commit to the repository # FeatureContext::iShouldBeAbleToPushACommitToTheRepository()

Additionally, there are some given/when/then issues.

In the first scenario, instead of:

    And I am on the Version control tab
    Then I initialize the repository

which are both changing the state of the system, I would expect to see:

    And I am on the Version control tab
    And I initialize the repository
    Then I should see "some sign of success visible to the user"

Likewise for the third scenario. Instead of:

    When I clone the repo
    Then I should be able to push a commit to the repository

I would expect to see something more like:

    When I clone the repo
    And I push a commit
    Then I should see "some sign of success visible to the user"

~
~

Unassigning - FYI, I automatically review anything that is set to needs review with a component of Feature/Scenario.

Looks ready for code review.

merged to master

marking fixed

Removed the @wip and failure tags - these are as ready as they can be until the D7 Drupal.org is ready for feedback.

.