There has been some discussion regarding the functionality of the enter key over here #1730012: Can not add new terms. It appears that the 2.x version of autocomplete_deluxe has removed the using enter key for confirming selection (or submitting new terms) in favour of using the comma key . I think this is a mistake. I think the enter key is far more intuitive. I see why you would want to keep the enter key for submitting the form, but I don't think that has to be the only function for the enter key on a form. Consider what happens when you hit enter in a text area. It's a new line; the form isn't submitted. People expect that and are okay with it. I think the same would be for the autocomplete deluxe field. The enter key would just serve a different purpose and I don't think people would be confused when it doesn't submit the whole form.
Additionally, I've noticed that people expect the comma key to be accepted as part of a new term. On the last site I launched recently that used the acdx widget, the first call I got was a few days after when they tried to add the taxonomy term: "Books, Cards & Gifts". There was no way for them to do it. They couldn't figure out why every time they hit the comma key, the word "Books" got added to the list. If you removed the comma key functionality as it is now, terms with commas in them could be accepted (see #1326444: Allow tags with comma's, e.g. "English, British")
Furthermore, I don't think that keeping this widget inline with the way core does it is necessary. IMHO, this widget is supposed to be an improvement on the core widget and shouldn't necessarily be tied down to work the same way. On sites that I use it on, it completely replaces the core autocomplete widget. When clients ask why the comma key doesn't work, I can't just tell them "because the old autocomplete widget did it that way" because they've never even used the old widget.
Anyway, I really love what this module does, but I'm finding the comma/enter key thing very difficult to explain to average user / clients. Also I'd noticed the debate going on in a couple other issues but I feel as though it's a big enough issue to warrant it's own thread.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | autocomplete_deluxe-fix_enter_key-1743136-3.patch | 913 bytes | jlancaster |
Comments
Comment #1
jlancaster commentedAgree. Enter key functionality is very expected and should continue to exist. The chosen plugin uses enter still, so this module should as well.
Comment #2
JohnnyX commentedYes, should work with enter!
Follow here...
Comment #3
jlancaster commentedThis is an easy feature to add into the module with the attached patch. I hope the maintainer will consider utilizing some sort of approach like this in future 2.x versions. I hope this helps with your client experiences!
Comment #4
JohnnyX commentedPatch works so far! Thanks! :)
I noticed a double backspace remove added tags (like one click at "X"). Bug or feature?
Found it by during remove typed word...
Maybe it should not remove ALL terms is I hold down backspace key...
Comment #5
sepgil commentedUsing the enter key now works for the dev version, but I haven't removed the comma, since I really need it. Maybe we can make it optional? But lets open a new issue for that.
Comment #6
drclaw commentedI'd love to see comma key functionality as an option. Maybe we can discuss that here: #1326444: Allow tags with comma's, e.g. "English, British"?
Comment #7
sepgil commentedno, please open new issue. #1326444: Allow tags with comma's, e.g. "English, British" is fixed for 2.x
Comment #8
drclaw commentedOops... Already posted in that queue. I'll open a new one.