I use version 7.x-1.x-dev. The automatic Updatefunction from Drupal cant update to 7.x-1.4. There is only a white screen after download and then klick the update-button!

CommentFileSizeAuthor
#6 zipcart-missing-js-settings-1743514-6.patch14.05 KBdigitalfrontiersmedia

Comments

caw67’s picture

caw67 commented
Priority: Normal » Critical

what about this issue??? it doesnt work (update to. 7.1.4)

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Title: Cant update » Automatic upgrade to 7.x-1.4 fails
Status: Active » Postponed (maintainer needs more info)

I'd appreciate if you can provide some debug output on this, as I don't have any Drupal sites with FTP enabled to test it on.

http://drupal.org/node/158043 - in particular turn on error reporting and check your server log files to see what exactly is failing.

caw67’s picture

caw67 commented

turned on error reporting. only white screen appears.
and its not a memory problem, because all other modules i can update.

caw67’s picture

caw67 commented

Got it: Parse error: syntax error, unexpected ',', expecting ')' in /sites/all/modules/zipcart/zipcart.module on line 365
Here is the original line: drupal_add_js(, 'setting');
here corrected: drupal_add_js('setting');

caw67’s picture

caw67 commented

But now when I try to add some file to the cart this error shows:
Fatal error: Call to undefined function file_check_location() in /var/www/vhosts/cc-isobus.de/httpdocs/sites/all/modules/zipcart/zipcart.module on line 241

And there is no more a ZIP Cart Block!!!

digitalfrontiersmedia’s picture

digitalfrontiersmedia
Location Sarasota, FL
commented
StatusFileSize
new zipcart-missing-js-settings-1743514-6.patch14.05 KB

here corrected: drupal_add_js('setting');

This is incorrect. Line 365 should be:

  drupal_add_js($settings, 'setting');

Patch attached below rolled against Master branch, which appears to be quite different from the recommended release. If I'm supposed to roll this patch against a different branch or something, let me know. This patch seems to include a lot of minor Drupal coding standards fixes in addition to the correction noted above.

caw67’s picture

caw67 commented

thanks! i will try the patch. but first only the correct line...
when i only correct the line 365, it the module doesnt work.
i will try the patch next days....

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Postponed (maintainer needs more info) » Needs review

Thanks DigitalFrontier & caw67, I believe this issue in 7.x-1.4 is already fixed in 7.x-1.x-dev and will be happy to roll a new release if you can confirm that upgrading to the dev tarball fixes the issue for you.

caw67’s picture

caw67 commented

The new dev-Version works for me! ;) Great! Thanks!

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Needs review » Fixed

Thanks. 7.x-1.5 should be available soon with that fix in it. Thanks for reporting this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.