On the project page it says that Ember can be used standalone but many references to items in style.css reference locations that could only happen if the theme was installed in profiles/spark/themes/ember and assumes the other modules are present in the install profile as well.

Comments

tkoleary’s picture

tkoleary commented

I'm pretty sure I have fixed all instances of this in the 8.x branch. Need to backport.

tkoleary’s picture

tkoleary commented
Status: Active » Postponed (maintainer needs more info)

@Dave Reid

Don't see any instances of this in the current 7.x branch. Which file did you see this in?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I'm not sure 100% what I was referring to back in August of last year. But looking at the most recent code I can see the following:

.item-list ul li.collapsed,
 168 ul.menu li.collapsed {
 169   list-style-image: url(../../misc/menu-collapsed.png);
 170   list-style-type: disc;
 171 }
 172 .item-list ul li.expanded,
 173 ul.menu li.expanded {
 174   list-style-image: url(../../misc/menu-expanded.png);
 175   list-style-type: circle;
 176 }

I'm not sure that using two levels of parent directories is correct here. It seems like this code is incorrectly sampled from existing core themes, in which it's safe to refer to the misc directory like this because we can always assume those themes live in themes/theme-name. A contrib theme has no such luxury since this CSS file could live in multiple possible directories: sites/all/themes/contrib/ember/css/style.css, sites/default/themes/foo/bar/ember/css/style.css, or profiles/spark/themes/ember/css/style.css.

tkoleary’s picture

tkoleary commented

@Dave Reid

Ah. Yes. I see. That makes sense. I'll remove the extra level up.

tkoleary’s picture

tkoleary commented
Assigned: Unassigned » tkoleary
tkoleary’s picture

tkoleary commented
Status: Postponed (maintainer needs more info) » Needs work
tkoleary’s picture

tkoleary commented
Status: Needs work » Closed (fixed)