I guess messages like "Click here to view this message on the web." are not visible in admin/config/regional/translate/translate because in the php of this module is missing the t function.
Would be nice to use it.

CommentFileSizeAuthor
#5 htmlmail-d6-text-translation-1744200-5-do-not-test.patch530 bytesjacob.embree
#2 1744200-text-translation.patch877 bytesStevel

Comments

splatterb0y’s picture

splatterb0y commented
Category: feature » bug

This is because it's hardcoded into the 'htmlmail--simplenews.tpl.php', this should be mapped to a variable or something.

Stevel’s picture

Stevel commented
Version: 7.x-2.8 » 7.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new 1744200-text-translation.patch877 bytes

Here is a patch that makes the text at least translateable.

RunePhilosof’s picture

RunePhilosof commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Looks good

sylvaticus’s picture

sylvaticus commented

I am also affected by this problem.. would it be possible to commit it ? It's a very simple patch that surelly doesn't have tremendous side effects...

jacob.embree’s picture

jacob.embree commented
StatusFileSize
new htmlmail-d6-text-translation-1744200-5-do-not-test.patch530 bytes

Confirmed #2 works.

This patch is a backport for 6.x-2.x-dev in case #2 ever gets committed. Fixes #2015951: Make htmlmail--simplenews.tpl.php strings translatable.

salvis’s picture

salvis
he/his
commented
Status: Reviewed & tested by the community » Needs review

Let's see whether #2 applies.

  • salvis committed 5c540cf on 7.x-2.x 
    Issue #1744200 by Stevel: Text cannot be translated.

  • salvis committed 3622052 on 6.x-2.x 
    Issue #1744200 by Stevel, jacob.embree: Text cannot be translated.
salvis’s picture

salvis
he/his
commented
Status: Needs review » Fixed

Thanks, Stevel and jacob.embree!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.