Referencing to #1742734: [META] Widgets as Plugins.

Code is committed in branch [edit: field-plugins-yched-widgets-only] field-plugins-widgets-1742734

Comments

tsphethean’s picture

tsphethean commented

Just run a few tests having pulled the latest version of the branch and the number field appears to be functioning as expected.

I do now get a notice output on the Field edit screen:

Notice: Indirect modification of overloaded element of Drupal\field\Field\FieldInstance has no effect in field_default_form() (line 68 of core/modules/field/field.form.inc).

nils.destoop’s picture

nils.destoop commented

We are aware of the notice. It's not caused by the number plugin itself, and occurs on every field that uses the new widgets. It was also mentioned at #1742734: [META] Widgets as Plugins

yched’s picture

yched commented
Status: Active » Fixed

Those warnings should be fixed in the field-plugins-widgets-1742734 branch now.

I think we can call this fixed now ?

yched’s picture

yched commented
Title: Implementation of field type Number » Implementation of Number widgets

more accurate title

Stalski’s picture

Stalski commented

imo yes, I think we can merge that one in and I'll do some more testing.

yched’s picture

yched commented

Unless, I'm mistaken, it's merged in already :-)

Stalski’s picture

Stalski commented

yeah sorry :)
Fixed some fatal and working on the legacyWidget with zuuperman.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.