Based on #1741094: [meta] Move as much metadata out of annotations as possible we should should convert this three flags, which are connected to each other in one part.

CommentFileSizeAuthor
#9 1744334-uses_fields_row_class_plugin-9.patch21.8 KBdawehner
#9 interdiff.txt16.72 KBdawehner
#7 interdiff.txt931 bytesdawehner
#6 1744334-uses_fields_row_class_plugin-6.patch10.92 KBdawehner
#4 1744334-uses_fields_row_class_plugin-4.patch9.39 KBdawehner
#1 1744334-uses_fields_row_class_plugin.patch9.41 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 1744334-uses_fields_row_class_plugin.patch9.41 KB

Here is a first version for that.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +VDC

.

Status: Needs review » Needs work

The last submitted patch, 1744334-uses_fields_row_class_plugin.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new 1744334-uses_fields_row_class_plugin-4.patch9.39 KB

Tim found the problem with calling !empty()

Here is a new version of the patch

Status: Needs review » Needs work

The last submitted patch, 1744334-uses_fields_row_class_plugin-4.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Title: Convert uses_row_class, uses_row_plugin, and uses_fields » Move uses_row_class, uses_row_plugin, and uses_fields from plugin annotation to a class property
Status: Needs work » Needs review
StatusFileSize
new 1744334-uses_fields_row_class_plugin-6.patch10.92 KB

I had missing one of them, but hey that's what we have tests for.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new interdiff.txt931 bytes

.

Status: Needs review » Needs work

The last submitted patch, 1744334-uses_fields_row_class_plugin-6.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt16.72 KB
new 1744334-uses_fields_row_class_plugin-9.patch21.8 KB

Updated to use camelCase.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

This looks good to me. At first I was confused by the 'uses_fields' in lib/Drupal/views/Plugin/views/style/StylePluginBase.php, but those are for a form field!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Closed (fixed) » Active
Issue tags: +Needs change record
xjm’s picture

xjm
she/her
Primary language English
commented
Title: Move uses_row_class, uses_row_plugin, and uses_fields from plugin annotation to a class property » [Change notice] Move uses_row_class, uses_row_plugin, and uses_fields from plugin annotation to a class property
Issue tags: -Needs change record
xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Needs change record
chris matthews’s picture

chris matthews commented
Project: Views (for Drupal 7) » Drupal core
Version: 8.x-3.x-dev » 8.7.x-dev
Component: Code » views.module
Issue summary: View changes

For more information as to why this issue was moved to the Drupal core project, please see issue #3030347: Plan to clean process issue queue

chris matthews’s picture

chris matthews commented
Project: Drupal core » Views (for Drupal 7)
Version: 8.7.x-dev » 7.x-3.x-dev
Component: views.module » Code
Status: Active » Closed (outdated)

Moving back to the contributed Views issue queue and closing as outdated per https://www.drupal.org/project/views/issues/3030347#comment-13023447