Logo title is not localizable [#17446]

Using the XTemplate engine the logo title is not localizable. Consequently, all default themes use a title and alt string of "Home" which is language specific.

The attached patch solves the problem by adding a site_name variable to the logo block and replacing the title and alt strings with {site_name}.

This patch only updates the "bluemarine" and "pushbutton" themes.

Comments

Comment #1

(not verified) CreditAttribution: commented 17 February 2005 at 19:46

+1 - had to manually change this in my theme

Comment #2

Steven CreditAttribution: Steven commented 21 February 2005 at 04:06

I don't think it makes sense to replace the "Home" title by the site name. In fact, we also use "Home" as title for the site name link itself, so there it certainly doesn't make sense.

I'd say we should simply keep the word "home" (or "front page" or whatever), but put it in a {home} tag so it can be localized.

Comment #3

tangent CreditAttribution: tangent commented 21 February 2005 at 04:47

I have no objection to using {home} for the link title instead of the site name but I think using "Home" for the img alt text is inappropriate. This string should describe the img and not where the link goes to.