Coming back to Sasson and this caught me again so I thought I'd get around to filling an issue :)

CommentFileSizeAuthor
#5 drush-sns-sass-path-1744988.patch2.54 KBmxmilkiib

Comments

mxmilkiib’s picture

mxmilkiib commented
Title: drush sns makes paths with 'all/themes, not active site directory » drush sns makes paths with 'all/themes', not active site directory
tsi’s picture

tsi commented

This was implemented long time ago, so I don't know what to say...
This is how we do it (/includes/sasson.drush.inc) :

  // From Sasson's location, we move up one directory and construct the path where
  // our sub theme will be created.
  $_sasson_path = explode('/', $sasson_path);
  array_pop($_sasson_path);
  $theme_dir = implode('/', $_sasson_path);
  $subtheme_path = $theme_dir . '/' . $machine_name;

can you explain what exactly is happening ?

mxmilkiib’s picture

mxmilkiib commented

Apologies, was rather tired last night, got myself mixed up.

The subtheme installs into the right place, but the sasson_watch_file path in the newsubtheme.info is incorrect.

settings[sasson_watch_file] = 'sites/all/themes/test/stylesheets/test.scss'

when test is in sites/mysite.com/themes/test

sasson.drush.inc has;
drush_op('sasson_file_str_replace', "$subtheme_path/$machine_name.info", 'SUBTHEME', "$machine_name");

A more specific path replacement at that point would sort it.

tsi’s picture

tsi commented
Priority: Normal » Minor
Status: Active » Needs work

I see, so the issue is only with an editable placeholder that is only there as an example.
It *is* a valid issue but no biggie :)
Patches anyone ?

mxmilkiib’s picture

mxmilkiib commented
Status: Needs work » Needs review
StatusFileSize
new drush-sns-sass-path-1744988.patch2.54 KB

My first patch, think this does it right..

n.b. It didn't activate or set the theme correctly before, and it still doesn't yet, but "drush_pm_enable($machine_name);" looks legit..

tsi’s picture

tsi commented
Status: Needs review » Fixed

Sorry, don't know how I've missed this.
Committed and fixed. thanks.
http://drupal.org/commitlog/commit/31168/8092dd353d1715d7c5c1379ea867c78...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.