Reject non-routable IP addresses makes field required to work.

sgriffin - September 10, 2007 - 22:19
Project:CCK IP Address
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:minor
Assigned:firebus
Status:postponed (maintainer needs more info)
Description

When "Reject non-routable IP addresses" is checked..
You MUST enter in a valid ip on your node.

Otherwise, 0.0.0.0 is entered and fails the check.
This makes it so ip address or ip range becomes a required field which shouldn't be the case.

#1

firebus - September 10, 2007 - 23:12
Assigned to:Anonymous» firebus
Status:active» fixed

ugh. i was lazy about comparing 0 to empty string AND i was casting empty strings as '000' with sprintf!

i have this fixed i think and will commit in a moment.

#2

sgriffin - September 11, 2007 - 02:17

I uploaded your commits for .module and .css but I still receive for a blank range...
Illegal value for range_ip 1, second address. Non-routable IP addresses are not allowed.

I went down from multiple to single and it left some weird ass field after the first ip range. I guess thats it.

Its a label for something I guess. So maybe thats not the issue.

#3

firebus - September 11, 2007 - 16:42
Status:fixed» postponed (maintainer needs more info)

i'll do some more testing in the next week and see if i can reproduce.

can you tell me what version of cck you're using (i doubt that's the issue, but i have discovered some version specific cck issues in the past...)

#4

sgriffin - September 12, 2007 - 05:48

I downloaded the updated cck ip module just in case, and the new cck. It seems good. No issues.

 
 

Drupal is a registered trademark of Dries Buytaert.