[Change notice] Move use_ajax form plugin annotation to class property.

Apart from title and help, what should we do with the other properties? Should we do the same? I don't really know from how many places those are called and what / whether more files would be affected.

I think we should try to port them in groups which are logically connected, like uses_fields, uses_row_plugin, uses_row_class.

Thanks for you patch!

I have looked at the patch and i realized that the default of the value is set to TRUE, so only subclasses which changes that need to have this value. On the other side you somehow missed to rename the calls, so there was still $this->use_ajax used,
so here is a new version for that.

tim will kill you for having camelcase properties:

+ protected $usesAjax = TRUE;

Hmm why define this property again in Feed?

+ /**
+ * Whether the display uses AJAX or not.
+ *
+ * @var bool
+ */
+ protected $usesAjax = FALSE;

I would just set the basePlugin $uses_ajax in the constructor

lowerCamelCase properties are correct.
And overriding it is how we did the other ones, so that's fine.

Whoops I was mixing properties with variable names. (/me is still tired)
Oh rly? Never done such things before in other programming languages but whateva :)

Rtbc than

+++ b/lib/Drupal/views/Plugin/views/display/DisplayPluginBase.phpundefined
@@ -340,12 +347,11 @@ abstract class DisplayPluginBase extends PluginBase {
-  function use_ajax() {
-    if (!empty($this->definition['use_ajax'])) {
-      return $this->get_option('use_ajax');
-    }
-    return FALSE;
+  function usesAjax() {
+    return $this->usesAjax;

@@ -1239,7 +1245,7 @@ abstract class DisplayPluginBase extends PluginBase {
-    if (!empty($this->definition['use_ajax'])) {

Mh, this sadly changes the logic. Sadly that's my fault, but to keep a good standard we should talk about how to handle that.

For example $this->definition['use_ajax'] could directly use $this->usesAjax instead of calling the function. Alternative an additional parameter could also help. Any opinions?

We kind of agreed that there should be two methods:

1. getUsesProperty for just getting the definition on the object
2. usesProperty to take into account the actual option as well

Here is a patch which should do that.

if you go with that I should rename the property too

+++ b/lib/Drupal/views/Plugin/views/display/DisplayPluginBase.phpundefined
@@ -57,6 +57,13 @@ abstract class DisplayPluginBase extends PluginBase {
+   * Whether the display allows the use of AJAX or not.

This makes sense as a comment.

+++ b/lib/Drupal/views/Plugin/views/display/DisplayPluginBase.phpundefined
@@ -339,10 +346,21 @@ abstract class DisplayPluginBase extends PluginBase {
+   * Does the display type allows the use of AJAX?

This does not make sense as a comment.

allowsAjax to usesAJAX
isAjaxEnabled to isAJAXEnabled

Still the same and don't forget the property

That seems good to me.

Committed it now!

For more information as to why this issue was moved to the Drupal core project, please see issue #3030347: Plan to clean process issue queue

Moving back to the contributed Views issue queue and closing as outdated per https://www.drupal.org/project/views/issues/3030347#comment-13023447