The 3.x branch of the Libraries module depends on System stream wrapper, and many modules depend on the Libraries module, so upgrading this module to D8 is prerequisite for upgrading many other modules.

CommentFileSizeAuthor
#9 1748556.5.system_stream_wrapper-8.x.patch47.79 KBdeviantintegral
#5 1748556.5.system_stream_wrapper-8.x.patch47.79 KBdeviantintegral
#4 1748556.4.system_stream_wrapper-8.x.patch47.62 KBdeviantintegral
#3 1748556.3.system_stream_wrapper-8.x.patch53.35 KBdeviantintegral
#1 system_stream_wrapper-d8upgrade-1748556-1.patch13.56 KBbenshell

Comments

benshell’s picture

benshell commented
Status: Active » Needs review
StatusFileSize
new system_stream_wrapper-d8upgrade-1748556-1.patch13.56 KB

Here's a patch to get started with moving this module to D8. It seems to be working for my needs for now, although I have not tested extensively.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Status: Needs review » Postponed

Looks like at least some basic implementation of this contrib module will get merged into D8 core (#1308152: Add stream wrappers to access .json files in extensions), so we have to postpone and wait to see if there's anything left at all to extend in contrib.

deviantintegral’s picture

deviantintegral commented
Issue summary: View changes
Status: Postponed » Needs work
StatusFileSize
new 1748556.3.system_stream_wrapper-8.x.patch53.35 KB

Since this patch hadn't been touched in three years, I decided to redo it based off of https://www.drupal.org/node/1308152#comment-10842840

This patch is nearly identical in code to the upstream issue, with changes in namespaces and so on. Tests are failing for me so this still needs some work. However, with this I'm able to make a basic library:// stream wrapper that I'll post in a followup issue.

deviantintegral’s picture

deviantintegral commented
StatusFileSize
new 1748556.4.system_stream_wrapper-8.x.patch47.62 KB

That patch actually contained the library wrapper, so here's a reroll without it.

deviantintegral’s picture

deviantintegral commented
StatusFileSize
new 1748556.5.system_stream_wrapper-8.x.patch47.79 KB

Fixes the tests by ensuring system and system_stream_wrapper are enabled.

deviantintegral’s picture

deviantintegral commented
Status: Needs work » Needs review
deviantintegral’s picture

deviantintegral commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
deviantintegral’s picture

deviantintegral commented
Status: Needs review » Needs work
deviantintegral’s picture

deviantintegral commented
Status: Needs work » Needs review
StatusFileSize
new 1748556.5.system_stream_wrapper-8.x.patch47.79 KB

Trying to kick off the testbot.

deviantintegral’s picture

deviantintegral commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.