Closed (won't fix)
Project:
Webform
Version:
7.x-4.0-alpha4
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
24 Aug 2012 at 03:13 UTC
Updated:
4 Mar 2015 at 17:21 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
berenddeboer commentedAnd here the patch.
Comment #2
berenddeboer commentedOops, had left some debug code. This patch is better, and behavior is slightly optimised. The only thing to be aware of is one must select the preceding page break to skip to, not the question itself.
Comment #3
berenddeboer commentedAnd more bug fix.
Comment #4
quicksketchThanks for the patch! Overall, I'm not 100% sure about this approach, but if it were integrated it would at least need:
1) To restrict the list of options (via JavaScript) to just page breaks when using "skip-to". It doesn't make any sense to show users options that don't work. PHP validation should also be in place to prevent saving the form if an invalid (non-pagebreak) option is selected.
2) To follow coding standards. See http://drupal.org/coding-standards.
Comment #5
berenddeboer commentedThanks for the quick feedback quicksketch. I've attached a patch that takes care of 2 and does the php error handling of 1. Need a bit more free time for the javascript patch.
Comment #6
berenddeboer commentedUpdated against latest webform.
Comment #7
xadag commentedDo you think this patch is compatible with the 4.1 branch because some part of the code didn't match any part of the new code in the 4.1 branch
Thanks.
Comment #8
danchadwick commentedYou can hide entire pages by hiding the page break. Not sure if that helps. That notwithstanding, I don't see this being implemented. I don't see the corresponding jQuery code in the patch, which is needed to work intra-page.
I am also not convinced that "skip to" is the right UI element. I can imagine selecting a set of components to be hidden at once, however. I suspect that has nasty data structure ramifications, however.