Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
#1734648: Media 2.x branch missing dependencies outlined that the dependency generation used by drupal.org testbots does not yet respect versioned dependencies and will ignore them.
Media should use an unversioned dependency on File Entity to facilitate testing on d.o.
I believe that this blocks all testing issues including #1733960: Cleanup existing tests.
Comment | File | Size | Author |
---|---|---|---|
#11 | media-requirements-install-profile-1749252-11.patch | 469 bytes | jhedstrom |
#5 | 1749252-hook_requirements_follow_up-5.patch | 1.16 KB | ParisLiakos |
#1 | use-unversioned-dependencies-1749252-1.patch | 369 bytes | Devin Carlson |
Comments
Comment #1
Devin Carlson CreditAttribution: Devin Carlson commentedThe attached patch changes the versioned dependency on file_entity to an unversioned dependency.
Comment #2
aaron CreditAttribution: aaron commentedmaybe we can implement hook_requirements instead. I will leave that for another issue though, as I see no reason to hold up testing further over that.
Comment #3
ParisLiakos CreditAttribution: ParisLiakos commentedthanks, commited
Comment #4
Dave ReidWe need to have a hook_requirements check as a critical follow-up. This is one of the major things that bites people on the upgrade path from 1.x to 2.x.
Comment #5
ParisLiakos CreditAttribution: ParisLiakos commentedSomething like this
Comment #6
Devin Carlson CreditAttribution: Devin Carlson commented#1: use-unversioned-dependencies-1749252-1.patch queued for re-testing.
Comment #7
Devin Carlson CreditAttribution: Devin Carlson commentedUpdated title.
Comment #8
ParisLiakos CreditAttribution: ParisLiakos commentedswapped t() with get_t() and commited this.
see
http://drupalcode.org/project/media.git/commit/3f4c786
Comment #9
ParisLiakos CreditAttribution: ParisLiakos commentedhttp://drupal.org/node/1496624#comment-6667974
maybe i should remove this check on install and leave it only on update...it actually makes sense..
Comment #10
jmpease CreditAttribution: jmpease commentedI'm trying an install using the 2.x media_dev profile and am getting a "The specified database connection is not defined: default" notification in the "Verify requirements" stage. It appears to be related to http://drupalcode.org/project/media.git/commit/3f4c786 as commenting out the hook_requirements impl allows me to continue with the install.
Comment #11
jhedstromThis change also broke installation profiles that attempt to enable media during site installation.
Changing to only check on update fixes the issue for me.
Comment #12
ParisLiakos CreditAttribution: ParisLiakos commentedyeap:)
committed #11 thanks for the patch
http://drupalcode.org/project/media.git/commit/83c903d
Comment #13
knalstaaf CreditAttribution: knalstaaf commentedI'm still getting this error:
I used the patch of #5 (above) and the File Entity patch of #175 in #1553094: Alt and Title support for Images.
I'm also using this patch, but I've got no idea if it's of any relevance in this case (#1244476: Add an "Override image style" setting to the rendered file formatter).
The module versions:
Can someone help me out please?
Edit [10-11-2012]: my apologies for the (unintended) hijack of this thread. The solution to this issue can be found here.
Comment #14
ParisLiakos CreditAttribution: ParisLiakos commentedDont hijack fixed issues for support requests.please open a new issue