#1734648: Media 2.x branch missing dependencies outlined that the dependency generation used by drupal.org testbots does not yet respect versioned dependencies and will ignore them.

Media should use an unversioned dependency on File Entity to facilitate testing on d.o.

I believe that this blocks all testing issues including #1733960: Cleanup existing tests.

CommentFileSizeAuthor
#11 media-requirements-install-profile-1749252-11.patch469 bytesjhedstrom
#5 1749252-hook_requirements_follow_up-5.patch1.16 KBParisLiakos
#1 use-unversioned-dependencies-1749252-1.patch369 bytesdevin carlson

Comments

devin carlson’s picture

devin carlson commented
Status: Active » Needs review
StatusFileSize
new use-unversioned-dependencies-1749252-1.patch369 bytes

The attached patch changes the versioned dependency on file_entity to an unversioned dependency.

aaron’s picture

aaron commented
Status: Needs review » Reviewed & tested by the community

maybe we can implement hook_requirements instead. I will leave that for another issue though, as I see no reason to hold up testing further over that.

ParisLiakos’s picture

ParisLiakos commented
Status: Reviewed & tested by the community » Fixed

thanks, commited

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Priority: Normal » Major
Status: Fixed » Needs work

We need to have a hook_requirements check as a critical follow-up. This is one of the major things that bites people on the upgrade path from 1.x to 2.x.

ParisLiakos’s picture

ParisLiakos commented
Assigned: devin carlson » ParisLiakos
Status: Needs work » Needs review
StatusFileSize
new 1749252-hook_requirements_follow_up-5.patch1.16 KB

Something like this

devin carlson’s picture

devin carlson commented

#1: use-unversioned-dependencies-1749252-1.patch queued for re-testing.

devin carlson’s picture

devin carlson commented
Title: Use unversioned dependency on File Entity to enable automated testing on drupal.org » Add check for File entity 2.x to installation requirements

Updated title.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Fixed

swapped t() with get_t() and commited this.
see
http://drupalcode.org/project/media.git/commit/3f4c786

ParisLiakos’s picture

ParisLiakos commented
Status: Fixed » Needs work

http://drupal.org/node/1496624#comment-6667974

maybe i should remove this check on install and leave it only on update...it actually makes sense..

jmpease’s picture

jmpease commented

I'm trying an install using the 2.x media_dev profile and am getting a "The specified database connection is not defined: default" notification in the "Verify requirements" stage. It appears to be related to http://drupalcode.org/project/media.git/commit/3f4c786 as commenting out the hook_requirements impl allows me to continue with the install.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs work » Needs review
StatusFileSize
new media-requirements-install-profile-1749252-11.patch469 bytes

This change also broke installation profiles that attempt to enable media during site installation.

WD php: PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'hf.system' doesn't exist: SELECT * FROM   [error]
{system} WHERE type = 'theme' OR (type = 'module' AND status = 1) ORDER BY weight ASC, name ASC;

Changing to only check on update fixes the issue for me.

ParisLiakos’s picture

ParisLiakos commented
Assigned: ParisLiakos » Unassigned
Status: Needs review » Fixed

yeap:)
committed #11 thanks for the patch
http://drupalcode.org/project/media.git/commit/83c903d

knalstaaf’s picture

knalstaaf commented
Status: Fixed » Needs review

I'm still getting this error:

Failed: PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'sitename1.file_type' doesn't exist: INSERT INTO {file_type} (type, label, description) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2); Array ( [:db_insert_placeholder_0] => [:db_insert_placeholder_1] => [:db_insert_placeholder_2] => ) in file_type_save() (regel 541 van /home/usr1/sitename/public_html/sites/all/modules/file_entity/file_entity.file_api.inc).

I used the patch of #5 (above) and the File Entity patch of #175 in #1553094: Alt and Title support for Images.

I'm also using this patch, but I've got no idea if it's of any relevance in this case (#1244476: Add an "Override image style" setting to the rendered file formatter).

The module versions:

  • Media 7.x-2.x-dev
  • File entity 7.x-2.x-dev

Can someone help me out please?

Edit [10-11-2012]: my apologies for the (unintended) hijack of this thread. The solution to this issue can be found here.

ParisLiakos’s picture

ParisLiakos commented

Dont hijack fixed issues for support requests.please open a new issue

Status: Needs review » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.