twig: themes/seven/page.tpl.php

moving to sandbox

I'll take a crack at this.

Beat me to it! :P

This looks good to me. Patch installed fine and everything seems to be printing fine.

I just noticed that Seven's page.tpl — and therefore the new twig file — doesn't print the logo or slogan. Is this correct? Seems a bit odd.

Regardless this has indeed been twiggified.

You're welcome! ;) Yeah, the lack of logo or slogan is because Seven is an admin theme, meant mainly as bread to the overlay sandwich, and not as an entrée.

I'm going to postpone this one until after we decide the core page.tpl.php is done - which probably won't be until after we have a theme component library, and the markup gets rewritten to use it.

I'm just worried that if we start "overriding" that file before it's done we'll have to keep changing all 3 templates with each change. (We may decide to do that at some point anyway - but I think it's too soon now).

Unfortunately we duplicated this effort over at #1938848: seven.theme - Convert PHPTemplate templates to Twig which ended up looking pretty similar.

Might be worth a second look to see if anything covered here can be merged.

Updated issue summary.