Closed (fixed)
Project:
Project issue tracking
Version:
5.x-2.x-dev
Component:
Issues
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
12 Sep 2007 at 05:45 UTC
Updated:
20 Oct 2007 at 18:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
dwwYup, there's no easy way to do this, currently. That sucks. Here's a patch that adds an admin setting to specify this. Really, I'd like this to be configurable directly in the UI by each user, but an admin setting is a start...
Comment #2
sickhippie commentedDWW, have I told you lately that you're totally awesome? You've been so much help in the last couple weeks while I've been setting these modules up for my company. Thanks!
Comment #3
dwwThanks.
However... does the patch work for you? ;) Praise is one thing, help is another... ;)
cheers,
-derek
Comment #4
sickhippie commentedWell, actually - it's not working for some reason. It seems that the patch is looking for project_issue.module 1.37 and issue.inc 1.249. I've got the right version of issue.inc, but my project_issue.module is 1.36. It's the one that is in the current release.
Any ideas?
Comment #5
dwwRight, that's the latest copy in CVS. Grab the 5.x-1.x-dev snapshot release and the patch should apply cleanly.
Comment #6
sickhippie commentedWorks like a dream, sir! Thanks again!
Comment #7
hunmonk commented/// How many issues should be displayed per page by default.-- does three slashes have some special significance, or is that a typo?$form['project_issues_per_page'] = array(-- there's an extra space in that line.Comment #8
dww- phpdoc considers /// to be a valid 1-liner phpdoc comment.
- a select box is needlessly restrictive IMHO, and doesn't really save us anything. we'd still need to validate it to catch people who alter the POST data (e.g. via firebug), and then we'd just get issues from people complaining that our "reasonable defaults" aren't what they want.
- extra space removed. ;)
Comment #9
hunmonk commentedi'm almost positive this is incorrect, due to the choice checker that's built into select validation.
i use selects to build reasonable defaults all the time, and i don't recall ever getting a complaint or issue filed because of the 'limitation'
so i'm not buying your arguments :)
Comment #10
sickhippie commentedI've agree with DWW on this point - I prefer inputting a number I choose for pagination instead of picking from a preselected list.
Comment #11
hunmonk commentedeither one will work, i think. the tradeoff here is slightly simpler code (read easier to maintain) for slightly less flexibility. i feel confident that a select list of 10-15 reasonable defaults will be plenty flexible enough.
that being said, this probably isn't a discussion worth too much wrangling over.
Comment #12
dwwCommitted #8 to HEAD and DRUPAL-5. Normally we wouldn't add new features to the stable series, but this is so minor I figured I'd allow an exception. ;) Plus, it's only really going to be useful to 5.x-1.* sites, since in 5.x-2.* all of this will soon be handled via views, and then the views UI lets you control the # of nodes per page. See http://drupal.org/node/76725.
Comment #13
(not verified) commented