Allow query strings in "from" paths

Yes, this seems like a helpful feature.

I do not have time to code it myself right now, but if anyone wants to submit a patch, I'll be happy to take a look.

Hi Jjeff,

We've updated the module and it all seems to be working fine. I have attached the file. If you want to go through it and see what we have done the changes have mainly been made to the init function and the admin pages (to not block questionmarks) and are commented.

If we have any problems I will let you know but this has been in use for over 24 hours and created over 100 redirects already which are all working well.

Regards,

Ryan

www.networkmenus.co.uk

Hi, Ryan. Any chance you could upload a patch for your modifications?

Seconded!

Here is Ryan's version, in patch form, and with the block that prevented redirects with query strings deleted instead of commented out. I haven't had a chance to test it yet. It looks like there are some things that could be cleaned up a little to match the Drupal code conventions.

And here is another patch--also untested!--which makes it a little clearer what is going on in the patch, I think. I can't vouch for its correctness, just that it's more obvious what it's trying to do. :)

It would also be great if there was an API call to add redirects.

Other modules that are importing content from another CMS could use this API to automatically setup all the necessary redirects.

Created a separate feature request for the API call to add redirects:
http://drupal.org/node/181575

Can somebody please post a patch against 5.x-1.1? Which version is the above path_redirect_query_6.patch made for? -dev? -HEAD?

Thanks very much!

#6 was made against something in the DRUPAL-5 branch; I don't know specifically what version. Here is an updated version against the latest 5.x-1.x-dev. I haven't tested it with clean URLs off, which will probably not work. There is a validation warning that will need to be fixed, too.

But this patch does basically work. If I can clean up those problems and get some testing, I'll get this committed. It's a pretty minor change that makes this module much more useful for people migrating to Drupal!

This version works with and without clean URLs, it appears. The validation warning I mentioned was from another issue I'm working on, so we can ignore that.

One issue remains to be resolved. If I have a redirect from /foo to /bar defined, it would be very reasonable to expect /foo?jub=jub to get redirected to /bar?jub=jub, or at least to just /bar. In fact, I'd bet people are counting on that behavior in the current version. This patch breaks that.

To preserve that behavior, we could first check for whatever was requested, including the query string, and if that doesn't turn up a match, check for what was requested without the query string. In other words, you'd match the most specific thing you could and redirect accordingly.

This patch addresses the issue I mentioned in #11 above.

#12 doesn't work if you have Drupal installed somewhere other than at the root. This patch fixes that. It works with and without clean URLs, in the root or in a subdirectory.

My only concern about this version is whether or not we can count on Drupal's base_path() being available and accurate during path_redirect_init. It doesn't seem to cause any problems when I fiddle with the "performance" settings, at least.

subscribing

Committed! The 6.x branch is back up to date with the changes in the 5.x branch, too. Nothing for 4.x, unfortunately.

Automatically closed -- issue fixed for two weeks with no activity.

I think there is still a bug, i have a multilingual website with drupal 6. path redirect does not redirect path(s) which only include for example ?id=5. i checked the source code and realized that the problem is because of the following code :

Would you please apply this change.

@sinasalek: That completely ruins the SQL and should not be used. Please file a new issue instead of opening up one that's been closed since Feb 2008.