In the project review thread, patrickd wrote:

I didn't have a look at all of the code, but where I looked at it's pretty clean and I don't thing here are major issues.

So I went over to test the module

  • [1] After installing the submodules I had to re-clear the cache, so the admin items actually appeared. strange
  • [2] All requirements of libraries should also be validated on the status reports page by hook_requirements()
  • [3] When editing and creating positions, you don't check whether the "number of vacancies" really is a number
CommentFileSizeAuthor
#2 election_cache_fix-1749846-2.patch988 bytespjcdawkins

Comments

pjcdawkins’s picture

pjcdawkins commented
Title: Fix patrickd's issues » Admin items do not appear on installing submodules without clearing the cache
Version: » 7.x-1.x-dev
Category: task » bug
Priority: Normal » Minor

Fixed [2] and [3], so re-purposing this issue to deal with [1].

I think it's to do with the difference between hook_menu() and hook_menu_alter().

pjcdawkins’s picture

pjcdawkins commented
Status: Active » Fixed
StatusFileSize
new election_cache_fix-1749846-2.patch988 bytes

I think this would do it - a static cache reset. I've committed this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Numbered items