Closed (fixed)
Project:
Privatemsg
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Aug 2012 at 14:31 UTC
Updated:
17 Jun 2013 at 20:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
valderama commentedHere is a patch..
Comment #2
valderama commentedsetting to needs review,
thanks,
walter
Comment #3
sutharsan commentedI think the patch is good, but IMHO for the wrong reason. It does not strip spaces, unless someone translated '[user]' with at space.
What is t('[user]') doing here anyway? The string should not be translated at all, it is a token. It is not even the value of the token.
Comment #4
ptmkenny commentedPatch should not be accepted "as is" because of the issue with t() noted in #3.
Comment #5
sutharsan commented@ptmkenny, but what problem are we solving here? In my view the patch is good, because it removes an unwanted t().
Comment #6
ptmkenny commentedAh, sorry, I misread your comment. Setting it back...
Comment #7
berdirCommitted and pushed to all relevent patches, thanks for testing.