Saving selected languages under text formats doesn't work

Confirmed.

More info on how to reproduce:
"Use text format specific tag settings." has to be enabled on the general GeSHi filter admin page
On a text format settings page (With GeSHi filter enabled): GeSHi settings are not saved (not only language tags)

Also confirmed. When editing a text format, if I try to add in a tag/attribute value within the GeSHi filter settings it won't save, yet doesn't give an error that it hasn't saved.

I confirm, if you tick "Use text format specific tag settings." there is no way to update language configuration in gesh filter tab

Same problem here -- though when I enable Use text format specific tag settings" I can no longer even get back to the configuration page at all.

I am having similar issue. I am using the latest stable version of this module. After installing, I added a new language from the module configuration page admin/config/content/formats/geshifilter/languages/all. The new language added is visible in the text format section (for example Filtered HTML) admin/config/content/formats/filtered_html as show below.

However, when I am adding "TAG/LANGUAGE ATTRIBUTE VALUE" as show above and saving the form, then it is not saving.

Am I skipping anything in the configuration? Any help in this will be appreciated.

+1 We are experiencing the same issue.

Also confirmed. new tags/attributes are not saved without any error

It is saved, but we use it wrong!

The settings for each filter are the same way as drupal 8, the settings are in $format->settings['setting'], but we use someting like $variable['setting_filterformat'].

So we have two options: when the filter is saved, we save everything we need by hand in $variable(which is used now, except that we do not save) or change everything to use $format->settings. I will work on a fix for it by saving to $variable, if i use $filter->settings, i will have to add $filter to a dozen of function calls and pass it everywhere.

This commit fix this by using $variable['setting'] not $format->settings(which would be better) but now it works.

There is no tests because tests are broken, but with this i can work on tests now in #2161119: Fatal error in tests: Call to undefined function db_result()..

Please test it and report any issue.

While working on tests, i found that validation is not working, so you can have the same tag for more than one language, back to needs work :(

This is fixed now. Since we have a new structure in the form array that is not the same as the form in language, i made a copy from the function used in languages, and changed it to work with new form structure.

I did a manual test and it work with the tests, so all tests pass now, this will help the work on other issues too.