Comments

nod_’s picture

use .on()

not much else.

kiphaas7’s picture

BONUS: Investigate if adding basic events and detach makes sense, as described in #1763812: [META] Provide complete attach/detach with basic events

Definately could use detach and events.

nod_’s picture

tag

internetdevels’s picture

Issue summary: View changes
StatusFileSize
new4.66 KB

little clean-up

nod_’s picture

We cleaned up the .trigger, .on and all a while back. If you look closely, the blur and focus calls are methods from the model, not jQuery things.

nod_’s picture

Status: Active » Needs work
kiphaas7’s picture

And the patch has two typos:
model.close().trigge('blur');
this.model.triger('focus');

droplet’s picture

Status: Needs work » Needs review
StatusFileSize
new5.39 KB

- rename Storage to sessionStorage, more easier to read (sometimes, we use localStorage)

manuel garcia’s picture

Parent issue: » #1574470: Selectors clean-up
rteijeiro’s picture

StatusFileSize
new4.92 KB

Re-rolled!

nod_’s picture

Status: Needs review » Closed (fixed)

Already been cleaned in another issue (don't know which one, just know it's fine now).

Left over changes do not improve things much.