Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
javascript
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 Aug 2012 at 15:29 UTC
Updated:
14 May 2015 at 10:03 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
nod_use .on()
not much else.
Comment #2
kiphaas7 commentedBONUS: Investigate if adding basic events and detach makes sense, as described in #1763812: [META] Provide complete attach/detach with basic events
Definately could use detach and events.
Comment #3
nod_tag
Comment #4
internetdevels commentedlittle clean-up
Comment #5
nod_We cleaned up the .trigger, .on and all a while back. If you look closely, the blur and focus calls are methods from the model, not jQuery things.
Comment #6
nod_Comment #7
kiphaas7 commentedAnd the patch has two typos:
model.close().trigge('blur');this.model.triger('focus');Comment #8
droplet commented- rename Storage to sessionStorage, more easier to read (sometimes, we use localStorage)
Comment #9
manuel garcia commentedComment #10
rteijeiro commentedRe-rolled!
Comment #11
nod_Already been cleaned in another issue (don't know which one, just know it's fine now).
Left over changes do not improve things much.