Selectors clean-up: menu module

selector in admin js are real bad.

wierd thins in menu.js

Just as i patched this I noticed #1660952: Replace all jQuery.each() with filtered for loop, but as that issue is regarding $.each I decided to roll one with everything except for the loop change.

nice :)

so first .on you could bind it to the #edit-menu and use event delegation selecting input.
use camelcase variables, no underscore
you don't have to scope the id selector

good work, thanks!

Thanks for the review, here's a modified version.

I keep forgetting to tag as NR

Reroll

should probably pull the new changes, patch doesn't apply either.

Whops,

Hope it goes better this time.

There is another patch to replace the jQuery each with a filtered for loop, can you make the change in here already ?

(edit) apart from that it's good to go :)

Sure, are you fine with renaming index machineName? I had to log it myself to understand what it was therefore I think machineName is more readable, if not I'll reroll.

Naming changes like that, which only help readability, are more than welcome.

Looks good to go, this clears up a lot of weird stuff that was going on there.

Looks like great clean-up. Committed/pushed to 8.x.