Part of the JavaScript selectors clean-up effort.
#1574470: Selectors clean-up
#1415788: Javascript winter clean-up

CommentFileSizeAuthor
#11 drupal-clean_up_node_module-1751406-11.patch10.07 KBrteijeiro
#7 drupal-clean_up_node_module-1751406-7.patch9.36 KBinternetdevels
#2 core-js-1751406-2.patch3.61 KBjelle_s

Comments

nod_’s picture

nod_
Primary language French
Location Lille
commented

bad selectors in content_types.js

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Active » Needs review
StatusFileSize
new core-js-1751406-2.patch3.61 KB

rough patch, probably needs some more work, just to get this started...

Status: Needs review » Needs work
Issue tags: -JavaScript clean-up

The last submitted patch, core-js-1751406-2.patch, failed testing.

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs work » Needs review
Issue tags: +JavaScript clean-up

#2: core-js-1751406-2.patch queued for re-testing.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue tags: +Needs JavaScript testing

tag

droplet’s picture

droplet commented
Status: Needs review » Needs work

- Needs prefix jQuery object with $
- Remove "fieldset" on ID selectors ?

internetdevels’s picture

internetdevels commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new drupal-clean_up_node_module-1751406-7.patch9.36 KB

alansaviolobo queued 7: drupal-clean_up_node_module-1751406-7.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 7: drupal-clean_up_node_module-1751406-7.patch, failed testing.

manuel garcia’s picture

manuel garcia commented
Parent issue: » #1574470: Selectors clean-up
rteijeiro’s picture

rteijeiro commented
Status: Needs work » Needs review
StatusFileSize
new drupal-clean_up_node_module-1751406-11.patch10.07 KB

Re-rolled!

droplet’s picture

droplet commented
Status: Needs review » Closed (works as designed)

Thanks for great work! I reviewed it again. It's already done in other issues.