Closed (won't fix)
Project:
Drupal core
Version:
8.0.x-dev
Component:
javascript
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
24 Aug 2012 at 16:05 UTC
Updated:
14 May 2015 at 13:57 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
nod_The way things work here is pretty crazy. Animation is bad and this is the slowest script (by far) of Drupal core.
Comment #2
nod_Ok, better title :)
Comment #3
nod_Comment #4
nod_tag
Comment #5
nod_Comment #6
droplet commentedWorking on a related topic, make a quick patch but doesn't meant to cleaup all stuff.
(I'll be back if no one work on it)
Comment #7
nod_closing this one as dup: #567192: Clean up Javascript implementation of Expanding simpletest groups
Comment #8
mgiffordtagging.
Comment #9
quicksketchSeems like a good idea to me. I like the animation but it's fine if it gets the ax. We've got a lot more tests now than we did when this was written.
Considering the number of tests we have, it'd be a much better idea to bind to the entire table rather than each individual collapse arrow using the new jQuery $.on() method. This makes it so we only need one binding on the page instead of ~100.
Comment #10
wim leers#9++
This is so dog slow that it's frustrating to run tests (and the CLI test runner is broken, at least in D8). The animation may not be the best JS, but it's fine perf-wise. It's the "group checkbox" stuff that is so frustrating.
Unfortunately, a quick test revealed that even if we *don't* do the group checkbox updating thing (only insert the group checkboxes upon initialization, no correlated checkbox updating thing), then it's *still* equally slow. This is in the latest Chrome. So I honestly don't see how we can fix this :/It turns outtableselect.jsis the culprit for a lot of the slowness! So this issue won't have much (or even any) effect unless we also improve that JS…Comment #11
wim leersSo …
tableselect.jsreally is the cause of all this slowness. Apply the attached patch and be delighted. You might even put away that knife that you wanted to use to stab your eyes out. (OTOH, with this patch applied, if you want to run *all* tests, now you'll want to use the aforementioned knife to check the zillion checkboxes on your screen.)Setting to NR to get some attention for this new-found information.
Comment #12
xjmTHANK YOU for this; this bug drives me absolutely crazy.
Comment #13
tim.plunkettI use the simpletest UI a ton, and I've NEVER used the test group checkboxes, always individually selecting tests.
So +1
Comment #15
droplet commented@11~13,
check it out:
#1880798: tableselect.js performances
Comment #16
nod_2 years without complaints, not worth it to refactor now.