As highlighted in the issue #1741444: Current Search text items are double escaped when translated, Facet API double encoded the Current Search text items. In addition, a more permissive filter should be used since only privileged administrators have access to configure this setting.

CommentFileSizeAuthor
#5 double-encoding-fix-1751514-5.patch3.51 KBcpliakas
#2 double-encoding-fix-1751514-2.patch2.86 KBcpliakas
#1 double-encoding-fix-1751514-1.patch6.14 KBcpliakas

Comments

cpliakas’s picture

cpliakas commented
Status: Active » Needs review
StatusFileSize
new double-encoding-fix-1751514-1.patch6.14 KB

The attached patch fixed the logic error in theme_current_search_text() and adds some tests to ensure the values are handled properly. The filter is also changed from filter_xss to filter_xss_admin() which is more appropriate given the privileges required to modify the setting.

cpliakas’s picture

cpliakas commented
StatusFileSize
new double-encoding-fix-1751514-2.patch2.86 KB

Ugh. Uncommenting code I commented out during testing.

Status: Needs review » Needs work

The last submitted patch, double-encoding-fix-1751514-2.patch, failed testing.

daniel kulbe’s picture

daniel kulbe
he/him
Primary language German
Location Berlin
commented
Status: Needs work » Reviewed & tested by the community

Works correct!

cpliakas’s picture

cpliakas commented
Version: 7.x-1.1 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new double-encoding-fix-1751514-5.patch3.51 KB

Thanks! I will take your RTBC as confirmation that the functionality works. Running through the testbot again, just to make sure the all the tests play nicely together.

cpliakas’s picture

cpliakas commented
Status: Needs review » Reviewed & tested by the community

Light is green, trap is clean. Re-marking as RTBC based on #1751514-4: Current search text items are double encoded.

cpliakas’s picture

cpliakas commented
Status: Reviewed & tested by the community » Fixed

Committed to all branches of Facet API.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.