Closed (fixed)
Project:
Jsdomenu
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Anonymous (not verified)
Created:
18 Feb 2005 at 16:08 UTC
Updated:
17 May 2005 at 16:59 UTC
Jump to comment: Most recent file
Comments
Comment #1
nedjoIt's a good suggestion. The fact is I don't use jsdomenu myself anymore, and so haven't given much attention to enhancements. As a minimum, I guess, I should update to the latest jsdomenu release. Some of what I tried with the previous releases didn't work in drupal, but more possibilities may be open. I'd certainly appreciate any patch that added functionality.
That said, in general I'm thinking that a pure CSS approach would be overall preferable. I started to rough one in awhile back but haven't had time to finish it.
Comment #2
joel_guesclin commentedWell, being an avid user of jsdomenu myself I liked this idea so much that I have done it. In fact I have hacked jsdomenu quite a bit so that:
- it supports version 1.3 of the jsdomenu javascript (which is what allows static menus)
- it supports any number of themes, not just the two provided as standard
- it supports nodes shown below the category
I would be happy to share this - am waiting for CVS approval by the Drupal team.
Comment #3
nedjoThat's great, thanks for your work. If you want to post a patch (or the revised module version) I'll happily apply it, or you can wait until you have CVS write access.
And, might you be interested in/willing to take over maintenance of the module?
Comment #4
joel_guesclin commentedI'm still waiting for accreditation as a contributor - I'm not sure how this works. Is there a problem because I have not enabled e-mail messaging to me, or is it just that everybody is snowed under with work because of bringing out 4.6.0?
Anyway, here is the new version all packaged up, including version 1.3 of jsDoMenu and the the two standard themes, as well as a pot file and the translated po file for French (which I've not yet tested by the way, so hope I've done everything right).
I noticed a couple of slightly weird things and maybe someone can explain the reasons:
- when I first installed the new version of jsdomenu, with the "visible" option, the menu items all appeared badly formatted at the bottom of the screen; I had to refresh the screen a couple of times before it started working properly, since then no problems. I wonder if this was something to do with having the javascript function and css class definitions already loaded in the browser, and them not getting immediately flushed from cache?
- I notice that there is a slight delay in the top-level menu displaying when I change pages.
I had thought that one might - at least if you don't display the node level - generate the menu in a cron job rather than doing it every page - thought this might give a performance improvement, on the assumption that you don't change the taxonomy that much and could stand waiting for cron to do it.
But basically, it seems to work. I don't mind mantaining it since I will use it on my site for the foreseeable future. I might even be tempted to included the "menu bar" option one of these days!
Any comments welcome
Comment #5
nedjoThanks, changes committed as 4.6 branch.
Comment #6
(not verified) commented