warning: Invalid argument supplied for foreach() in /all/modules/og_forum on line 692.

Using dev version now, still the problem persists:

warning: Invalid argument supplied for foreach() in /site.net/sites/all/modules/og_forum/og_forum.module on line 714.

Hello, you're right, I didn't read the post. Now I just did, and I'm still having a difficult time understanding exactly what is happening.

Let me restate the problem here, just to be clear:

When posting a new topic via link "post a new forum topic" from a forum, I get the following errors (different line numbers depending on whether it's in a group forum or not):

warning: Invalid argument supplied for foreach() in /home/.puppy/fredburks/portal.transformationteam.net/sites/all/modules/og_forum/og_forum.module on line 679.
warning: Invalid argument supplied for foreach() in /home/.puppy/fredburks/portal.transformationteam.net/sites/all/modules/og_forum/og_forum.module on line 715.

> Your error indicates that $form['taxonomy'][$vid]['#options'] doesn't exist.

I just followed your suggestion and in both cases with Admin and non-admin I got no values after "Taxonomy Options X:"

> This module doesn't originate that array. I'm pretty sure that comes from the basic forum module.

I looked in the forum module, and I can't seem to find where $form['taxonomy'] being set. There is $form['vid'], but ['#options'] is not set for it.

My forum module is a standard 5.2 core module.

I did a site-wide grep for $form['taxonomy'] and og_forum is the only module that mentions it.

What exactly does this function do? Everything seems to work when I have the admin forum privileges.

Any ideas?

Ahh, I have Category module installed, this may be where the problem lies. I just did a grep on my older backups of the site, and it looks like $form['taxonomy'] is set by taxonomy.module, and Category module provides a wrapper for it.

I just did a diff of my version of taxonomy wrapper against the latest one from Category module:

sites/all/modules/category# diff -up
 wrappers/taxonomy.module.copyme ../../../../modules/taxonomy/taxonomy.module
--- wrappers/taxonomy.module.copyme     2007-04-07 13:22:14.000000000 -0700
+++ ../../../../modules/taxonomy/taxonomy.module        2007-08-21 13:55:27.000000000
 -0700
@@ -863,6 +863,15 @@ function taxonomy_nodeapi(&$node, $op, $
     case 'load':
       $node->taxonomy = taxonomy_node_get_terms($node->nid);
       break;
+    case 'validate':
+      // Inject taxonomy into the form.
+      // This is needed for modules such as forum and simplenews,
+      // who check for taxonomy during validation and early submission.
+      global $form_values;
+      if (empty($form_values['taxonomy']) && !empty($form_values['category'])) {
+        $form_values['taxonomy'] = $form_values['category'];
+      }
+      break;
     case 'insert':
       if (category_is_cat_or_cont($node->nid)) {
         $type = category_node_get_type($node);

Interesting, that is a patch I applied a while back to fix something with forum compatibility (the "topic has been moved" problem).

Something didn't work with my previous grep results. Here they are again (grep -r "\$form\['taxonomy'\]"
*):

modules/taxonomy/taxonomy.module:  $form['taxonomy'] = array(
modules/taxonomy/taxonomy.module:      $form['taxonomy'] = array(
modules/taxonomy/taxonomy.module:      $form['taxonomy']['taxonomy_maintain_db'] = array(

and here are the results from one of my earlier backups (core 5.1, no Category)

modules/taxonomy/taxonomy.module:        $form['taxonomy']['tags'][$vocabulary->vid]
= array('#type' => 'textfield',
modules/taxonomy/taxonomy.module:        $form['taxonomy'][$vocabulary->vid] = taxonomy_form($vocabulary->vid, array_keys($default_terms), $vocabulary->help);
modules/taxonomy/taxonomy.module:        $form['taxonomy'][$vocabulary->vid]['#weight'] = $vocabulary->weight;
modules/taxonomy/taxonomy.module:        $form['taxonomy'][$vocabulary->vid]['#required'] = $vocabulary->required;
modules/taxonomy/taxonomy.module:    if (is_array($form['taxonomy']) && !empty($form['taxonomy'])) {
modules/taxonomy/taxonomy.module:      if (count($form['taxonomy']) > 1) { // Add fieldset only if form has more than 1 element.
modules/taxonomy/taxonomy.module:        $form['taxonomy'] += array(
modules/taxonomy/taxonomy.module:      $form['taxonomy']['#weight'] = -3;
modules/taxonomy/taxonomy.module:      $form['taxonomy']['#tree'] = TRUE;

It seems like the Category taxonomy wrapper sets a lot less things for $form['taxonomy'].

What do these scripts do in the og_forum module? Everything seems to work besides the error. Can I disable or work around them?

line 699 error:

      if (!user_access('administer forums')) {
        foreach ($form['taxonomy'][$vid]['#options'] as $key => $the_rest) {
          $option_key = key($the_rest->option);
          if (!array_key_exists($option_key, $all_results)) {
            unset($form['taxonomy'][$vid]['#options'][$key]);
          }
          elseif (array_key_exists($option_key, $all_results) && $all_results[$optio$
            unset($form['taxonomy'][$vid]['#options'][$key]);
          }
        }
        $form['og_nodeapi']['visible']['og_groups']['#value'] = $form['og_nodeapi'][$
        unset($form['og_nodeapi']['visible']['og_groups']['#default_value']);
        $form['og_nodeapi']['visible']['#access'] = 0;
      }

line 735 error:

      if (!user_access('administer forums') && $cut) {
        foreach ($form['taxonomy'][$vid]['#options'] as $key => $the_rest) {
          $option_key = key($the_rest->option);
          if (array_key_exists($option_key, $all_results)) {
            unset($form['taxonomy'][$vid]['#options'][$key]);
          }
        }
      }

Thanks for taking your time helping me with this,
Andrey.