Add a generic testcase for the argument_validator base [#1754234]

Comment	File	Size	Author
#26	vdc-1754234-26.patch	7.61 KB	dawehner
#26	interdiff.txt	850 bytes	dawehner
#24	drupal-1754234-24.patch	7.6 KB	dawehner
#24	interdiff.txt	490 bytes	dawehner
#17	views_argument_validator_tests-1754234-17.patch	7.56 KB	dawehner
#17	interdiff.txt	1.73 KB	dawehner
#15	drupal-1754234-15.patch	7.82 KB	djroshi
#15	interdiff.txt	1.05 KB	djroshi
#13	drupal-1754234-13.patch	7.76 KB	djroshi
#11	drupal-1754234-10.patch	5.18 KB	djroshi
#10	drupal-1754234-9.patch	7.77 KB	dawehner
#7	drupal-1754234-7.patch	7.57 KB	dawehner
#6	drupal-1754234-6.patch	7.48 KB	dawehner
#3	views-1754234-3.patch	4.67 KB	aspilicious
#1	views-1754234-1.patch	4.68 KB	dawehner

Comment #1

dawehner

German

commented 30 September 2012 at 19:27

Status:

Active

» Needs review

Status	File	Size
new	views-1754234-1.patch	4.68 KB

Added a test plugin and did some checking.

Log in or register to post comments

Comment #2

30 September 2012 at 19:36

Status:

Needs review

» Needs work

The last submitted patch, views-1754234-1.patch, failed testing.

Log in or register to post comments

Comment #3

aspilicious commented 7 October 2012 at 13:55

Status:

Needs work

» Needs review

Status	File	Size
new	views-1754234-3.patch	4.67 KB

I think there was a filename conflict with the previous patch

Log in or register to post comments

Comment #4

dawehner

German

commented 7 October 2012 at 15:19

Status:

Needs review

» Needs work

+++ b/lib/Drupal/views/Tests/UI/ArgumentValidatorTest.phpundefined
@@ -0,0 +1,30 @@
+  public function testArgumentValidatorUI() {
+

We don't test something yet, so this needs work.

Log in or register to post comments

Comment #5

xjm

she/her

English

commented 23 October 2012 at 01:31

Project:	Views (for Drupal 7)	» Drupal core
Version:	8.x-3.x-dev	» 8.x-dev
Component:	Code	» views.module

Log in or register to post comments

Comment #6

dawehner

German

commented 11 November 2012 at 20:31

Status:

Needs work

» Needs review

Status	File	Size
new	drupal-1754234-6.patch	7.48 KB

Wrote an actual test for the UI, so we have a basic test coverage for that specific area of the code.

Log in or register to post comments

Comment #7

dawehner

German

commented 17 January 2013 at 12:18

Status	File	Size
new	drupal-1754234-7.patch	7.57 KB

Updated against recent changes of views tests and fixed some codestyle issues.

Log in or register to post comments

Comment #8

17 January 2013 at 13:07

Status:

Needs review

» Needs work

The last submitted patch, drupal-1754234-7.patch, failed testing.

Log in or register to post comments

Comment #9

damiankloip commented 17 January 2013 at 17:33

+++ b/core/modules/views/lib/Drupal/views/Tests/Plugin/ArgumentValidatorTest.phpundefined
@@ -29,6 +31,12 @@ public static function getInfo() {
+    $this->enableViewsTestModule();

This is a method on ViewTestBase and not ViewUnitTestBase.

Log in or register to post comments

Comment #10

dawehner

German

commented 17 January 2013 at 21:09

Status:

Needs work

» Needs review

Status	File	Size
new	drupal-1754234-9.patch	7.77 KB

Let's fix those tests.

Log in or register to post comments

Comment #11

djroshi commented 9 February 2013 at 00:33

Status	File	Size
new	drupal-1754234-10.patch	5.18 KB

Apparently views.view.test_argument.yml was missing an id attribute, causing a fatal error in testArgumentValidatorUI()

Log in or register to post comments

Comment #12

dawehner

German

commented 9 February 2013 at 00:41

It feels really wrong that you removed some test code, which got added in #10 or before. Is there a specific reason for that?

Log in or register to post comments

Comment #13

djroshi commented 9 February 2013 at 00:57

Status	File	Size
new	drupal-1754234-13.patch	7.76 KB

I must have rolled the patch incorrectly, the only intended change (vs #10) is this >

+human_name: ''
+id: test_argument
+tag: ''

Log in or register to post comments

Comment #14

dawehner

German

commented 9 February 2013 at 01:59

+++ b/core/modules/views/tests/views_test_config/test_views/views.view.test_argument.ymlundefined
@@ -0,0 +1,40 @@
+      fields:
+        name:
...
+          table: views_test_data
+      arguments:
+        id:

Handlers now use "plugin_id", see views.view.test_view.yml

Did you ever used interdiffs? It's a great tool for collaborators to post changes on drupal.org, so these small changes are reviewable as well.

Log in or register to post comments

Comment #15

djroshi commented 9 February 2013 at 04:03

Status	File	Size
new	interdiff.txt	1.05 KB
new	drupal-1754234-15.patch	7.82 KB

Hopefully I got this right?

Log in or register to post comments

Comment #16

dawehner

German

commented 9 February 2013 at 09:23

I would love to RTBC it, though I wrote most of the code, so i'm stepping back.

A really tiny small """problem""".

+++ b/core/modules/views/tests/views_test_data/lib/Drupal/views_test_data/Plugin/views/argument_validator/ArgumentValidatorTest.phpundefined
@@ -0,0 +1,55 @@
+ * Contains Drupal\views\Plugin\views\argument_validator\ArgumentValidatorTest.

Nitpick :) Missing \ before Drupal.