Very simple SQL syntax cleanup: replace all value as placeholder, in order to keep code as cross database compatible.

CommentFileSizeAuthor
#5 bloat-175704-5.patch2.87 KBchx
drupal-6.x-dev-clean_query-0.1.patch13.01 KBhswong3i

Comments

chx’s picture

chx commented
Status: Needs review » Closed (won't fix)

This causes useless bloat as core works fine without this, there is no ground for this bloat. I will roll a patch which reverses every such patch from the past.

hswong3i’s picture

hswong3i commented
Status: Closed (won't fix) » Needs review

@chx: the won't fix or not shouldn't be judged by YOU: i will not oppose any action taken by core committers, but seems this is not your duty?

chx’s picture

chx commented

I won't fixed many issues in the past. This is neither the first or the last. It is bloat and bloat is against everything Drupal is.

hswong3i’s picture

hswong3i commented

@chx: just ask once again: are you core committer? if so, close my issue as you like; or else, comment about it and that's all :)

chx’s picture

chx commented
Title: SQL cleanup: /includes » Remove bloat from menu
StatusFileSize
new bloat-175704-5.patch2.87 KB

Thanks though for bringing this issue to my attention. I will roll one for system.install later.

hswong3i’s picture

hswong3i commented
Title: Remove bloat from menu » SQL cleanup: /includes

@chx: please don't mask up my progress result by your irrelevant patches. code cleanup is something often happened when project is going to launch (as we are all working for D6 beta1 now). i am just trying to cleanup those missing part that we are lose focus before. this issue is only a continue job, but not a new propose.

if you are trying to propose counter patches which will rollback our previous progress research result, please open your own issue :)

chx’s picture

chx commented

What you claim progress I claim is not what Drupal needs because it's bloat.

hswong3i’s picture

hswong3i commented
Assigned: Unassigned » hswong3i
Category: bug » task
Status: Needs review » Closed (won't fix)

Sounds not necessary based on my latest research result, if we are able to enclose all table/column/constraint name with [] syntax. That should belongs to D7, so we don't need to fix this issue right now :)