Improve test coverage for the entity form controller

See commit c6725b5 and the whole topic branch.

Tagging

Better title

Updated issue summary

Updated issue summary.

Moving to the core queue since this is a prerequisite for the work on the Entity Translation UI.

We need a patch from the topic branch here, back to active meanwhile.

More tags

Bumping to major since this is a blocker for the first UI patch.

Updated issue summary.

Simple and straightforward.

Sorry, just realized that the delete page callback is not used and needs to be removed:

+++ b/core/modules/entity/tests/modules/entity_test/entity_test.module
@@ -28,6 +31,68 @@ function entity_test_entity_info() {
+  $items['entity-test/manage/%entity_test/delete'] = array(
+    'title' => 'Delete test entity',
+    'page callback' => 'entity_test_delete',
+    'page arguments' => array(2),
+    'access arguments' => array('administer entity_test content'),
+    'type' => MENU_NORMAL_ITEM,
+  );

Since we are rolling a new patch can we perform the minor/cosmetic changes below?

+++ b/core/modules/entity/lib/Drupal/entity/Tests/EntityFormTest.php
@@ -0,0 +1,77 @@
+    entity_get_controller($entity_type)->resetCache();

It would be nice to add a comment explaining why we need this, something like:
"Always load the entity from the database to ensure that changes are correctly picked up."

+++ b/core/modules/entity/tests/modules/entity_test/entity_test.module
@@ -28,6 +31,68 @@ function entity_test_entity_info() {
+  drupal_set_title(t('Create an entity_test'), PASS_THROUGH);

Can we move this line up? Also, the PASS_THROUGH should not be needed here, since there is no HTML in the passed string.

Back to RTBC.

This no longer applies after the entity.module > \Drupal\Core\Entity move.

Rerolling

+    $entity->save();
+
+    $message = $entity->isNew() ? t('entity_test @id has been created.', array('@id' => $entity->id())) : t('entity_test @id has been updated.', array('@id' => $entity->id()));

After saving $entity->isNew() will never return TRUE, so this won't work as intended.

Rerolled and fixed #15 (the interdiff covers only the latter change).

Forgot to adjust some PHP docs.

I think #17 should be RTBC again.

Looks good!

Committed and pushed to 8.x. Thanks!

Thanks, removing from the sprint.